Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use latest action to replicate workflows to other repos #148

Merged
merged 8 commits into from
Apr 12, 2022

Conversation

derberg
Copy link
Member

@derberg derberg commented Mar 22, 2022

Description

  • use new version of action that copies files from this repo to other repos. It now supports not only workflow files
  • this change do not handle cleanup. Cleanup like removal go-related workflows from node project, or nodejs-related workflows from go projects is a manual work that has to be done by owners of related repositories when they have time. This action and workflow do not detect files that are no longer needed and therefor should be removed from some repo.
  • I don't think we should replicate other files than contributing guide and code of conduct. Imho support and other files can stay here as they are anyway supported by GitHub properly

TODO:

  • before it is merged I need to make sure CONTRIBUTING.md is only different for spec and community. Maybe other repos have their own versions
  • before it is merged I need to add proper topics to Go and NodeJS projects

Related issue(s)
Resolves #39
Resolves #40

@jonaslagoni pinging you as you are the owner of related issues
@smoya pinging you as you are owner of go projects
@KhudaDad414 pinging you for obvious reasons - I need your review
@magicmatatjahu pinging you so you know we can also have docker only workflows distributed only to repost with docker topic. Also new action also supports branches option, so we can do replication of files in branches different than main, in case we want.

KhudaDad414
KhudaDad414 previously approved these changes Mar 23, 2022
Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @derberg 🙇. love the new name of the action :)

@KhudaDad414
Copy link
Member

@HarshCasper you may be interested in this PR as well, for #147

@derberg
Copy link
Member Author

derberg commented Mar 23, 2022

@magicmatatjahu @jonaslagoni I went through all repos that have their own contributing guide. Some of them I ignore in new workflows. I need your opinion on what about:

my suggestion is to take "custom" parts into README.md into Development section, or Contributing section + switch to generic CONTRIBUTING.md

@magicmatatjahu
Copy link
Member

magicmatatjahu commented Mar 23, 2022

@derberg To correctly understand: do we need to remove our custom contribution guide and link to the CONTRIBUTING.md which will be copied to the every repo by "global" workflow or should this link point to a contribution in the community repo?

EDIT: Ok, I see we're going to have the CONTRIBUTING.md in every repo.

@derberg
Copy link
Member Author

derberg commented Mar 23, 2022

@magicmatatjahu you can have your custom CONTRIBUTING guide as you have now, but you can also have the one that we will copy over. Up to you. You will just need to move "custom" parts somewhere so they are not lost

with:
github_token: ${{ secrets.GH_TOKEN }}
patterns_to_include: .github/workflows/if-nodejs-pr-testing.yml,.github/workflows/if-nodejs-release.yml,.github/workflows/if-nodejs-version-bump.yml,.github/workflows/bump.yml
topics_to_include: nodejs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

topics_to_include is key. This is awesome. This is amazing 🥇 💯 👏

@smoya
Copy link
Member

smoya commented Mar 23, 2022

@derberg I added the golang topic into all go repositories that didn't have it.
Additionally, also added nodejs topic to https://github.com/asyncapi/server-api (I'm owner).

Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 tiny items 🎉🎉🎉

Co-authored-by: Alejandra Quetzalli  <[email protected]>
Copy link
Member

@quetzalliwrites quetzalliwrites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢

@derberg
Copy link
Member Author

derberg commented Mar 29, 2022

@magicmatatjahu @jonaslagoni so what is your take on mentioned CONTRIBUTING guides? should I add them to ignored for now?

@jonaslagoni
Copy link
Member

@magicmatatjahu @jonaslagoni so what is your take on mentioned CONTRIBUTING guides? should I add them to ignored for now?

Sounds good 👍

@derberg
Copy link
Member Author

derberg commented Apr 4, 2022

@magicmatatjahu pingy pongy

@magicmatatjahu
Copy link
Member

@derberg Sorry, I missed that notification. You can go ahead, as I see with react-component won't be problem.

@derberg
Copy link
Member Author

derberg commented Apr 11, 2022

all adjusted as requested
we also have nodejs topic added where needed, same with go thanks to @smoya

I need just one 🍏

smoya
smoya previously approved these changes Apr 11, 2022
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🌔

Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@derberg
Copy link
Member Author

derberg commented Apr 12, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 31b9746 into asyncapi:master Apr 12, 2022
@derberg derberg deleted the usenewglobal branch April 12, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Synchronize general documentation CONTRIBUTING file should be repository neutral
7 participants