-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use latest action to replicate workflows to other repos #148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @derberg 🙇. love the new name of the action :)
@HarshCasper you may be interested in this PR as well, for #147 |
@magicmatatjahu @jonaslagoni I went through all repos that have their own contributing guide. Some of them I ignore in new workflows. I need your opinion on what about:
my suggestion is to take "custom" parts into README.md into |
@derberg To correctly understand: do we need to remove our custom contribution guide and link to the EDIT: Ok, I see we're going to have the |
@magicmatatjahu you can have your custom CONTRIBUTING guide as you have now, but you can also have the one that we will copy over. Up to you. You will just need to move "custom" parts somewhere so they are not lost |
with: | ||
github_token: ${{ secrets.GH_TOKEN }} | ||
patterns_to_include: .github/workflows/if-nodejs-pr-testing.yml,.github/workflows/if-nodejs-release.yml,.github/workflows/if-nodejs-version-bump.yml,.github/workflows/bump.yml | ||
topics_to_include: nodejs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
topics_to_include
is key. This is awesome. This is amazing 🥇 💯 👏
@derberg I added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just 2 tiny items 🎉🎉🎉
Co-authored-by: Alejandra Quetzalli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🚢 🚢
@magicmatatjahu @jonaslagoni so what is your take on mentioned CONTRIBUTING guides? should I add them to |
Sounds good 👍 |
@magicmatatjahu pingy pongy |
@derberg Sorry, I missed that notification. You can go ahead, as I see with |
…o ignore for Contrib guide replication
all adjusted as requested I need just one 🍏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🌔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/rtm |
Description
removal go-related workflows from node project
, ornodejs-related workflows from go projects
is a manual work that has to be done by owners of related repositories when they have time. This action and workflow do not detect files that are no longer needed and therefor should be removed from some repo.TODO:
CONTRIBUTING.md
is only different for spec and community. Maybe other repos have their own versionsRelated issue(s)
Resolves #39
Resolves #40
@jonaslagoni pinging you as you are the owner of related issues
@smoya pinging you as you are owner of go projects
@KhudaDad414 pinging you for obvious reasons - I need your review
@magicmatatjahu pinging you so you know we can also have docker only workflows distributed only to repost with
docker
topic. Also new action also supportsbranches
option, so we can do replication of files in branches different than main, in case we want.