Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: new workflow to notify TSC members in slack #131

Merged
merged 4 commits into from
Feb 8, 2022

Conversation

derberg
Copy link
Member

@derberg derberg commented Feb 7, 2022

This workflow throws a message in a dedicated channel when there is a mention of the GitHub team that groups all technical steering committee members:

  • new discussion, issue or PR that mentions the team
  • new or edited comment in issue or PR that mentions the team (message links back to the comment)
  • new comment in discussion and new comment/reply to a comment in discussion (message links back to the comment)
  • reopened issue or PR that mentions the team

Because of if condition in the job, and not steps, workflow is skipped if TSC members are not mentioned

I tested this workflow in new channel 95_bot-tsc-members-mentioned. Below you can see example messages that were triggered from my test repo.

Screenshot 2022-02-07 at 16 07 26

See also asyncapi/community#253
This PR provides notifications to slack only for mentions.

Once we have a voting process facilitated, and we know how to do it, we will need to extend this workflow with new job that triggers a slightly different message, @channel with call for voting

@derberg derberg requested a review from KhudaDad414 February 7, 2022 15:17
Copy link
Member

@KhudaDad414 KhudaDad414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@derberg
Copy link
Member Author

derberg commented Feb 8, 2022

@KhudaDad414 thanks! I'll merge it later today as the other workflow update is in progress and it will take probably an hour to replicate

@derberg
Copy link
Member Author

derberg commented Feb 8, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit ae472b2 into asyncapi:master Feb 8, 2022
@derberg derberg deleted the newworkflowfortsc branch February 10, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants