Add an accept header in JSON request to help 3rd party services like …

…localstack (#1721)
async-aws · Jun 5, 2024 · 4a09fa9 · 4a09fa9
1 parent 6d8de00
commit 4a09fa9
Show file tree

Hide file tree

Showing 11 changed files with 34 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## NOT RELEASED
 
+### Changed
+
+- Add `Accept: application/json` header in request to fix incompatibility with 3rd party providers
+
 ## 2.1.1
 
 ### Changed

diff --git a/src/Input/BatchExecuteStatementRequest.php b/src/Input/BatchExecuteStatementRequest.php
@@ -173,7 +173,10 @@ public function getTransactionId(): ?string
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];

diff --git a/src/Input/BeginTransactionRequest.php b/src/Input/BeginTransactionRequest.php
@@ -102,7 +102,10 @@ public function getSecretArn(): ?string
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];

diff --git a/src/Input/CommitTransactionRequest.php b/src/Input/CommitTransactionRequest.php
@@ -89,7 +89,10 @@ public function getTransactionId(): ?string
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];

diff --git a/src/Input/ExecuteStatementRequest.php b/src/Input/ExecuteStatementRequest.php
@@ -242,7 +242,10 @@ public function getTransactionId(): ?string
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];

diff --git a/src/Input/RollbackTransactionRequest.php b/src/Input/RollbackTransactionRequest.php
@@ -89,7 +89,10 @@ public function getTransactionId(): ?string
     public function request(): Request
     {
         // Prepare headers
-        $headers = ['content-type' => 'application/json'];
+        $headers = [
+            'Content-Type' => 'application/json',
+            'Accept' => 'application/json',
+        ];
 
         // Prepare query
         $query = [];

diff --git a/tests/Unit/Input/BatchExecuteStatementRequestTest.php b/tests/Unit/Input/BatchExecuteStatementRequestTest.php
@@ -27,7 +27,8 @@ public function testRequest(): void
         // see https://docs.aws.amazon.com/rdsdataservice/latest/APIReference/API_BatchExecuteStatement.html
         $expected = '
             POST /BatchExecute HTTP/1.0
-            Content-Type: application/json
+            Content-type: application/json
+            Accept: application/json
 
             {
                "database": "my_database",

diff --git a/tests/Unit/Input/BeginTransactionRequestTest.php b/tests/Unit/Input/BeginTransactionRequestTest.php
@@ -19,7 +19,8 @@ public function testRequest(): void
         // see https://docs.aws.amazon.com/rdsdataservice/latest/APIReference/API_BeginTransaction.html
         $expected = '
             POST /BeginTransaction HTTP/1.0
-            Content-Type: application/json
+            Content-type: application/json
+            Accept: application/json
 
             {
                "database": "my_database",

diff --git a/tests/Unit/Input/CommitTransactionRequestTest.php b/tests/Unit/Input/CommitTransactionRequestTest.php
@@ -18,7 +18,8 @@ public function testRequest(): void
         // see https://docs.aws.amazon.com/rdsdataservice/latest/APIReference/API_CommitTransaction.html
         $expected = '
             POST /CommitTransaction HTTP/1.0
-            Content-Type: application/json
+            Content-type: application/json
+            Accept: application/json
 
             {
                "resourceArn": "arn:resource",

diff --git a/tests/Unit/Input/ExecuteStatementRequestTest.php b/tests/Unit/Input/ExecuteStatementRequestTest.php
@@ -38,7 +38,8 @@ public function testRequest(): void
         // see https://docs.aws.amazon.com/rdsdataservice/latest/APIReference/API_ExecuteStatement.html
         $expected = '
             POST /Execute HTTP/1.0
-            Content-Type: application/json
+            Content-type: application/json
+            Accept: application/json
 
             {
                "continueAfterTimeout": false,

diff --git a/tests/Unit/Input/RollbackTransactionRequestTest.php b/tests/Unit/Input/RollbackTransactionRequestTest.php
@@ -18,7 +18,8 @@ public function testRequest(): void
         // see https://docs.aws.amazon.com/rdsdataservice/latest/APIReference/API_RollbackTransaction.html
         $expected = '
             POST /RollbackTransaction HTTP/1.0
-            Content-Type: application/json
+            Content-type: application/json
+            Accept: application/json
 
             {
                "resourceArn": "arn:resource",