Add py.typed marker (PEP-561) #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without a py.typed marker, `mypy` and other type-checkers are unable to
use the provided type-hints - instead, they return errors like the
following mypy example when run with strict enough settings
```
path/to/file.py:1: error: Skipping analyzing "pyairnow.errors": module is installed, but missing
library stubs or py.typed marker [import-untyped]
from pyairnow.errors import EmptyResponseError
```
This change adds the required marker file and ensures it's built into
the final build artifact.
|
I tested this by pointing my project at a locally-built wheel with these changes, which then showed no |
|
Looks good, thanks @nemacysts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without a py.typed marker,
mypyand other type-checkers are unable to use the provided type-hints - instead, they return errors like the following mypy example when run with strict enough settingsThis change adds the required marker file and ensures it's built into the final build artifact.