Dynamic mock client (2) #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SEJeff
approved these changes
Jun 15, 2024
| prometheus.NewPedanticRegistry().MustRegister(collector) | ||
| ctx, cancel := context.WithCancel(context.Background()) | ||
| go collector.WatchSlots(ctx) | ||
| time.Sleep(1 * time.Second) |
There was a problem hiding this comment.
A waitgroup (from the sync package) is probably too much for tests, but is this necessary? Generally speaking, I see most code like this as code smell.
There was a problem hiding this comment.
It is to let the exporter run for a bit before we test it, to make sure it has gathered metrics before we go look what those metrics are and test them.
| @@ -1,10 +1,21 @@ | |||
| module github.com/certusone/solana_exporter | |||
|
|
|||
| go 1.13 | |||
| go 1.22 | |||
There was a problem hiding this comment.
Just pull this in from your rebase.
There was a problem hiding this comment.
The Go Update PR was to merge that branch into this branch
johnstonematt
force-pushed
the
provider-interface
branch
from
da8c6f3
to
aad48f6
Compare
johnstonematt
force-pushed
the
dynamic-mock-client
branch
from
89ebf69
to
214b737
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.