Type hints and type comments #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed conflicts, @asweigart could I get a review on this? |
Avasam
commented
Jul 11, 2023
Avasam
commented
Oct 20, 2023
Avasam
commented
Nov 12, 2023
|
@asweigart bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added python 3.4 compatible type comments to complete unknown types. And added the
py.typedmarker file so that type checkers like mypy, pyright and pytype know to use the inline types rather than looking for type stubs.Validated against Typeshed's CI: Avasam/typeshed#2
In the second commit, I've also added a script in
teststo run type-checking with both mypy and Pyright, for convenience.