Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OSX screenshot performance by immediately screenshot given region #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve OSX screenshot performance by immediately screenshot given region #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions pyscreeze/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import sys
import time
import errno
import tempfile

from contextlib import contextmanager

Expand Down Expand Up @@ -482,24 +483,18 @@ def _screenshot_osx(imageFilename=None, region=None):
"""
TODO
"""
# TODO - use tmp name for this file.
if imageFilename is None:
tmpFilename = 'screenshot%s.png' % (datetime.datetime.now().strftime('%Y-%m%d_%H-%M-%S-%f'))
else:
tmpFilename = tempfile.NamedTemporaryFile(suffix='.png').name
if imageFilename is not None:
tmpFilename = imageFilename
subprocess.call(['screencapture', '-x', tmpFilename])
im = Image.open(tmpFilename)

if region is not None:
if region is None:
subprocess.call(['screencapture', '-x', tmpFilename])
else:
assert len(region) == 4, 'region argument must be a tuple of four ints'
region = [int(x) for x in region]
im = im.crop((region[0], region[1], region[2] + region[0], region[3] + region[1]))
os.unlink(tmpFilename) # delete image of entire screen to save cropped version
im.save(tmpFilename)
else:
# force loading before unlinking, Image.open() is lazy
im.load()
subprocess.call(['screencapture', '-x', '-R', f'{region[0]},{region[1]},{region[2]},{region[3]}', tmpFilename])

im = Image.open(tmpFilename)
if imageFilename is None:
os.unlink(tmpFilename)
return im
Expand Down