-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to GTK+ version 3 #111
Conversation
This change seems to break Python 2's use of pyperclip. For Python 2 I would run What's the solution that doesn't break backwards compatibility? Is backwards compatibility important here? |
I would say that |
Are you able to apt install python-gi? That should get you py2 support. python3-gi should also be available for py3. |
The python-gi package exists in apt repos for Ubuntu 17.10, Ubuntu 16.04, Debian 9, and Debian 8 (all of the Linux VMs I had on hand to verify). @coreycb |
@tleonhardt I just checked and python-pi is available back to 12.04 for Ubuntu and looks to be available back to Debian 7. I'm not sure if there is a pip installable package. I didn't see one in my searches. |
I was just wondering if there was a way to still support people who have the older gtk module and not gi. Maybe we should add a I'm not familiar with gtk on Linux. Does this make sense? Or do we have to necessarily get rid of the |
I'm ok with a fallback mode. And as you said, if we did that I'd prefer importing gi first and falling back to gtk, because the import of gtk is why cmd2 and pyperclip currently fail when using interactive mode in Ubuntu. The gtk2 and gtk3 modules conflict. I'm not sure if you need to maintain backward compatability though on major releases of a project though, but I am not the maintainer. |
Note: You may also need libgtk-3-dev installed. |
@asweigart I've made some updates to fall back to gtk if gi is not available. |
@asweigart does this patch look ok to you? I really want to get this into ubuntu but would like it to land upstream here first. |
@asweigart Al, if you are busy, I'd be willing to help maintain |
Any news on this one ? An up-to-date patch is at https://github.com/sdelafond/pyperclip/blob/debian/master/debian/patches/move-to-gtk3.patch, just in case . |
Closing this. Thanks for your contributions and I'm sorry this slipped past my attention. I finally have some time to sort through the issues and PRs for pyperclip. I'll be adding you to the authors document so you can get recognition for your contribution. |
Fixes #106