Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure the directories and cosmetic updates on README #8

Merged
merged 11 commits into from
Mar 20, 2021
Merged

Restructure the directories and cosmetic updates on README #8

merged 11 commits into from
Mar 20, 2021

Conversation

jdlph
Copy link
Contributor

@jdlph jdlph commented Mar 20, 2021

Besides the directory changes and README updates, there are some functionality updates including,

  1. Adopt teestream.h for logging (i.e., simultaneously output log to terminal using std::cout and to local log.txt using std::ofstream);
  2. Replace non-standard #pragma once with include guard;
  3. Remove MathLibrary.cpp (which was removed) from CMakeLists.txt;
  4. Update CMakeLists.txt to specify C++ standard(i.e., C++11);
  5. Change argument list order in network_assignment() to be consistent with its counterpart in Path4GMNS;
  6. Provide executable of DTALite on macOS and move all executables to bin.

jdlph added 11 commits March 13, 2021 19:37
@jdlph
adopt teestream.h for logging
41919df 
- this is mainly for being used as shared library in Path4GMNS
- include teestream.h from DTALite_Refactor
- comment out outputting orgine zone id and destination zone id in
  g_ReadInputData().
- cosmetic changes in main_api.cpp and FlashDTA.cpp
@jdlph
repalce #pragma once with include guard
28ac58e
@jdlph
remove MathLibrary.cpp from CMakeLists.txt
0914682 
- this source file is no longer in use
- remove add_c() from MathLibrary.h which was defined in MathLibrary.cpp
- replace sprintf_s with sprintf
@jdlph
add executable on macOS and update .gitignore
c734fe8 
- do not track log.csv and .DS_Store
@jdlph
Merge branch 'main' of https://github.com/jdlph/DTALite into main
2b61601
@jdlph
update CMakeLists.txt to specify C++11
f6874c9 
- rename DLL_src to dll and Exe_src to exe
@jdlph
change argument list order in network_assignment()
124a3aa 
- the current order is int assignment_mode, int iteration_number,
  int column_updating_iterations, which is conistent with Python
  implementation
- switch back to ofstream to store log.txt as cout will ruin
  Jupyder notebook
@jdlph
Merge branch 'main' of https://github.com/asu-trans-ai-lab/DTALite in…
7143937 
…to main
@jdlph
restructure the directories
2c98a96 
- create folder DTALite and move all DTALite source files here
- create path_engine and move all shortest path engine source files used to
  build shared library here
- rename lib to bin where we store precompiled shared libraries
- remove output files in test data sets
@jdlph
cosmetic updates on README
feaee1c 
- embed links
- change headers
- change referrences in Other referrences to lists
@jdlph
Move DTALite executables from test_dll to bin
d8c5237
@xzhou99
Copy link
Contributor

xzhou99 commented Mar 20, 2021

confirm with the changes.

@asu-trans-ai-lab asu-trans-ai-lab merged commit 9cf3cd9 into asu-trans-ai-lab:main Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdlph @xzhou99 @asu-trans-ai-lab