MNT: Compat with pytest>=8 #15
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Can we just get rid of altogether it and copy-paste the GHA config over from doctestplus/remote-data? |
by copying over config from pytest-doctestplus to use Actions instead of Azure Pipelines. Added dependabot for future auto-updates. Updated Action version for publish workflow. Bump minimum versions to be consistent with pytest-doctestplus. Add change logs.
|
@bsipocz , good idea on the copy paste. I copied from doctestplus instead since I think that one was updated more recently? Anyway, shouldn't matter if I copied from doctestplus or remote-data. However, now that we have a proper pytest-dev job, it is failing because we have not merged this PR because apparently doctestplus is a test dependency here: |
I've restarted CI after the upstream merge. |
There was a problem hiding this comment.
Looks all good. I suppose the repeated ~20-25 lines could be dumped into a shared functions, but then it's borderline than just simply keep the repeats.
However, I think we need to add tests with the 8.0.x branch. I'm adding a commit with that, and if all CI is green, will go ahead and merge.
| python-version: '3.11' | ||
| toxenv: py311-test-pytest74 | ||
| toxargs: --pre | ||
| - os: macos-latest |
There was a problem hiding this comment.
If all else is looking good, I'll add the 8.0.x jobs here, too
| @@ -4,18 +4,18 @@ url = https://github.com/astropy/pytest-filter-subpackage | |||
| author = The Astropy Developers | |||
| author_email = [email protected] | |||
| classifiers = | |||
| Development Status :: 3 - Alpha | |||
| Development Status :: 5 - Production/Stable | |||
| @@ -1,7 +1,9 @@ | |||
| 0.1.3 (unreleased) | |||
There was a problem hiding this comment.
Given the stable metadata below, I would consider bumping the version number to either 0.2 or even 1.0
|
Thanks @pllim! |
|
Thanks for cleaning this up and merging! |
|
p.s. I pushed a commit directly to main to bump change log section to 0.2 to be consistent with milestone. FYI. |
|
yeap, I just added the milestone that was already around, but as I said above, I would not be against calling it v1.0 in the next release. |
|
Yeah, maybe it is time for 1.0. But... if you have plans to move this to Scientific Python, maybe we should wait for that first? Or is this too astropy specific? |
|
I don't see straight away who would be interested in using this (the main benefit is that this collects both from the source and docs, but if the narrative docs is not structured in the same submodule way, or doctesting is not done then there is no point using this.) So, we can certainly upstream it if there are other users, but first would need to find some interest. |
Fix #14 as suggested in pytest-dev/pytest#11779 (comment)
Out of scope: Fix the CI (looks very outdated but I don't have time to deal with it)