Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: avoid capturing stderr in tests using subprocesses #827

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

neutrinoceros
Copy link
Contributor

I scratched my head a couple minutes as I tried to understand why these tests were failing locally against numpy 2. Turns out, the error was trivial and had nothing to do with numpy:

ModuleNotFoundError: No module named 'psutil'

but it originally was not visible in pytest logs, so I propose to let stderr propagate naturally in this context to help future debugging.

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (b962f56) to head (995b028).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #827   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files           9        9           
  Lines        1392     1392           
=======================================
  Hits         1358     1358           
  Misses         34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwcraig mwcraig merged commit 5c7abc7 into astropy:main Apr 11, 2024
13 checks passed
@neutrinoceros neutrinoceros deleted the tst/dont_capture_stderr branch April 11, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants