Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: adapt a docstest for numpy 2 (representation of scalars changed) #826

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

neutrinoceros
Copy link
Contributor

@neutrinoceros neutrinoceros commented Apr 10, 2024

This is similar to astropy/astropy#15065
Since there is no simple way to have these doctests pass with both versions of numpy, my understanding is that this should be merged after numpy 2.0.0 final comes out.

xref: https://numpy.org/devdocs/release/2.0.0-notes.html#representation-of-numpy-scalars-changed

@neutrinoceros
Copy link
Contributor Author

It's not user impacting, but it might still be helpful to convert to a Python float so the test pass with any NumPy. Let me know if it seems acceptable to you @mwcraig

@mwcraig
Copy link
Member

mwcraig commented Apr 11, 2024

It's not user impacting, but it might still be helpful to convert to a Python float so the test pass with any NumPy. Let me know if it seems acceptable to you @mwcraig

This seems fine -- hopefully the next release of ccdproc (including the tests) can be compatible with both numpy 1.x mn numpy 2.x

@mwcraig
Copy link
Member

mwcraig commented Apr 11, 2024

@neutrinoceros -- can you please add yourself to the list of contributors? The changes you have been making have been super helpful!

@neutrinoceros
Copy link
Contributor Author

Sure thing. Let me open a separate PR for that !

@neutrinoceros
Copy link
Contributor Author

@mwcraig I just rebased this with the more portable change

@neutrinoceros neutrinoceros marked this pull request as ready for review April 11, 2024 14:50
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.62%. Comparing base (c72a2e9) to head (349ed6e).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #826      +/-   ##
==========================================
+ Coverage   97.55%   97.62%   +0.06%     
==========================================
  Files           9        9              
  Lines        1392     1388       -4     
==========================================
- Hits         1358     1355       -3     
+ Misses         34       33       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwcraig mwcraig merged commit 6927390 into astropy:main Apr 12, 2024
15 checks passed
@neutrinoceros neutrinoceros deleted the numpy2_doctests branch April 12, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants