Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interval Pixel Tree #249

Merged
merged 28 commits into from
Apr 11, 2024
Merged

Interval Pixel Tree #249

merged 28 commits into from
Apr 11, 2024

Conversation

smcguire-cmu
Copy link
Contributor

@smcguire-cmu smcguire-cmu commented Apr 3, 2024

Updates the PixelTree to use arrays of intervals instead of the tree data structure. Full details of this are described in this doc: https://docs.google.com/document/d/1gqb8qb3HiEhLGNav55LKKFlNjuusBIsDW7FdTkc5mJU/edit?usp=sharing

Closes #225

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 62.38095% with 79 lines in your changes are missing coverage. Please review.

Project coverage is 95.72%. Comparing base (bf275bc) to head (71c1c13).
Report is 8 commits behind head on main.

Files Patch % Lines
src/hipscat/pixel_tree/pixel_alignment.py 30.35% 78 Missing ⚠️
src/hipscat/pixel_math/healpix_pixel.py 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
- Coverage   99.94%   95.72%   -4.23%     
==========================================
  Files          57       56       -1     
  Lines        1995     1873     -122     
==========================================
- Hits         1994     1793     -201     
- Misses          1       80      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Apr 3, 2024

Before [4a31558] <v0.2.10> After [dbe3045] Ratio Benchmark (Parameter)
20.0±0.1ms 20.8±0.4ms 1.04 benchmarks.MetadataSuite.time_load_partition_info_order6
81.0±0.4ms 79.3±0.6ms 0.98 benchmarks.MetadataSuite.time_load_partition_info_order7
81.7±0.6ms 79.7±1ms 0.98 benchmarks.MetadataSuite.time_load_partition_join_info
126±0.6ms 124±0.6ms 0.98 benchmarks.time_test_alignment_even_sky
98.0±0.4ms 13.8±0.3ms 0.14 benchmarks.time_test_cone_filter_multiple_order
660±3ms 46.8±1ms 0.07 benchmarks.Suite.time_pixel_tree_creation

Click here to view all benchmarks.

src/hipscat/pixel_math/healpix_pixel.py Show resolved Hide resolved
src/hipscat/pixel_math/healpix_pixel.py Show resolved Hide resolved
src/hipscat/pixel_tree/pixel_tree.py Show resolved Hide resolved
src/hipscat/pixel_tree/pixel_alignment.py Outdated Show resolved Hide resolved
src/hipscat/pixel_tree/pixel_alignment.py Outdated Show resolved Hide resolved
src/hipscat/pixel_tree/pixel_alignment.py Show resolved Hide resolved
src/hipscat/pixel_tree/pixel_tree.py Show resolved Hide resolved
@smcguire-cmu
Copy link
Contributor Author

With the test coverage, even though it is run the compiled numba alignment code doesn't count towards the coverage

@smcguire-cmu smcguire-cmu merged commit e7b8f4c into main Apr 11, 2024
9 of 11 checks passed
@smcguire-cmu smcguire-cmu deleted the sean/interval-pixel-tree branch April 11, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize Pixel Tree
3 participants