Add docs comparing Python and YAML-based DAGs #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
==========================================
+ Coverage 93.31% 93.57% +0.25%
==========================================
Files 10 10
Lines 778 778
==========================================
+ Hits 726 728 +2
+ Misses 52 50 -2 ☔ View full report in Codecov by Sentry. |
Merged
pankajkoti
reviewed
Jan 3, 2025
Skipping 2.4 because:
FAILED tests/test_example_dags.py::test_example_dag[example_hackernews_dagfactory] - ImportError: Pandas requires version '0.9.0' or newer of 'tabulate' (version '0.8.10' currently installed).
FAILED tests/test_example_dags.py::test_example_dag[example_pypi_stats_dagfactory] - ImportError: Pandas requires version '0.9.0' or newer of 'tabulate' (version '0.8.10' currently installed).
Skipping 2.3 because:
ERROR tests/test_example_dags.py - AssertionError: assert not {'/home/runner/work/dag-factory/dag-factory/dev/dags/comparison/example_hackernews_plain_airflow.py': 'Traceback (most...ne, start_date=datetime(2022, 3, 4)) as dag:\nTypeError: __init__() got an unexpected keyword argument \'schedule\'\n'}
+ where {'/home/runner/work/dag-factory/dag-factory/dev/dags/comparison/example_hackernews_plain_airflow.py': 'Traceback (most...ne, start_date=datetime(2022, 3, 4)) as dag:\nTypeError: __init__() got an unexpected keyword argument \'schedule\'\n'} =
Skipping 2.2 due to:
same issue as 2.3
FAILED tests/test_example_dags.py::test_example_dag[example_hackernews_dagfactory] - ImportError: Pandas requires version '0.9.0' or newer of 'tabulate' (version '0.8.9' currently installed). FAILED tests/test_example_dags.py::test_example_dag[example_pypi_stats_dagfactory] - ImportError: Pandas requires version '0.9.0' or newer of 'tabulate' (version '0.8.9' currently installed).
pankajkoti
approved these changes
Jan 3, 2025
Co-authored-by: Pankaj Koti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation illustrating how two Airflow Python DAGs (one using traditional operators, another using TaskFlow API) are represented in Python (standard Airflow) and YAML (DAG Factory).
We use real-world data: one DAG uses Hacker News, and the other uses PyPI stats.
Before we merge this PR, I think we should merge #328 first and rebase this one. I isolated the tooling changes (mkdocs and others) in PR #328.
Close: #319