Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable secrect detection precommit check #281

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Enable secrect detection precommit check #281

merged 1 commit into from
Nov 5, 2024

Conversation

pankajastro
Copy link
Contributor

@pankajastro pankajastro commented Nov 5, 2024 •
edited
Loading

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.95%. Comparing base (cce8f05) to head (155f041).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #281   +/-   ##
=======================================
  Coverage   93.95%   93.95%           
=======================================
  Files           8        8           
  Lines         645      645           
=======================================
  Hits          606      606           
  Misses         39       39

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pankajastro pankajastro marked this pull request as ready for review November 5, 2024 08:07
@pankajastro pankajastro requested a review from a team as a code owner November 5, 2024 08:07
pankajkoti
pankajkoti approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@pankajastro pankajastro merged commit 841c5ff into main Nov 5, 2024
67 checks passed
@pankajastro pankajastro deleted the pecommit-secret-check branch November 5, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankajkoti pankajkoti pankajkoti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pankajastro @codecov-commenter @pankajkoti