Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove off looking start-date value in example_dag yaml config #273

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

pankajkoti
Copy link
Contributor

@pankajkoti pankajkoti commented Oct 22, 2024

The example_dag in the example_dag_factory.yml has a start_date
value set to 2 days, which seems unclear and problematic. It’s not clear
what this value represents, and it appears to be causing issues with the
DAG, preventing it from running tasks. I confirmed this issue also exists in
version 0.19.0, so it’s not related to any changes made after that version.
When I removed this questionable start_date value, the DAG ran its tasks
successfully.

closes: #274

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.96%. Comparing base (a947aa8) to head (6e1ccb7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage   93.96%   93.96%           
=======================================
  Files           8        8           
  Lines         630      630           
=======================================
  Hits          592      592           
  Misses         38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pankajkoti pankajkoti changed the title Remove off start-date value in example_dag yaml config Remove off looking start-date value in example_dag yaml config Oct 22, 2024
Copy link
Collaborator

@pankajastro pankajastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we remove end_date: 2018-03-05 too?

@pankajkoti
Copy link
Contributor Author

shall we remove end_date: 2018-03-05 too?

I guess we can keep it, it does not harm us, DAG runs are created & run fine until that end_date. And since we have been having it as example like this, I guess good to keep it as is without making much changes. WDYT?

@pankajkoti
Copy link
Contributor Author

shall we remove end_date: 2018-03-05 too?

I guess we can keep it, it does not harm us, DAG runs are created & run fine until that end_date. And since we have been having it as example like this, I guess good to keep it as is without making much changes. WDYT?

As discussed over Slack, I feel it's good to have that start_date - end_date time window to demonstrate that we're able to run DAGs using DAG factory (accepting those params well), so I'm going ahead with the merge. If the need is to support manual DAG runs, I suggest we create & add another example DAG without having an end_date, but for the given example I strongly believe it's a good example to have an end_date. I am going ahead with the merge now. Thanks for the review & the question :)

@pankajkoti pankajkoti merged commit 2f62442 into main Oct 22, 2024
67 checks passed
@pankajkoti pankajkoti deleted the fix-example-dag-config branch October 22, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

example_dag in example_dag_factory.yml does not run tasks
4 participants