Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor poor exception handling #259

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

tatiana
Copy link
Collaborator

@tatiana tatiana commented Oct 17, 2024

One exception was hiding the original problem and not giving further details.
The other exception handling didn't add any value.

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.35%. Comparing base (540b33a) to head (a36297b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
+ Coverage   89.04%   89.35%   +0.30%     
==========================================
  Files           8        8              
  Lines         648      648              
==========================================
+ Hits          577      579       +2     
+ Misses         71       69       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tatiana tatiana added this to the DAG Factory 0.20.0 milestone Oct 17, 2024
@tatiana tatiana merged commit 12ee7a9 into main Oct 17, 2024
35 checks passed
@tatiana tatiana deleted the refactor-poor-exception-handling branch October 17, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants