Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests #258

Merged
merged 7 commits into from
Oct 18, 2024
Merged

Add more tests #258

merged 7 commits into from
Oct 18, 2024

Conversation

pankajastro
Copy link
Collaborator

@pankajastro pankajastro commented Oct 17, 2024

closes: #199

  • Add test for the outlets param and load YML dag with default suffix cases
  • Cleanup some import for Airflow < 2.0.0

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.53%. Comparing base (79bc648) to head (70e029e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
+ Coverage   89.35%   92.53%   +3.18%     
==========================================
  Files           8        8              
  Lines         648      630      -18     
==========================================
+ Hits          579      583       +4     
+ Misses         69       47      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pankajastro pankajastro marked this pull request as ready for review October 17, 2024 13:50
tests/test_dagfactory.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pankajastro , a minor comment, and we're good to merge this!

@pankajastro pankajastro merged commit 7f6bdda into main Oct 18, 2024
35 checks passed
@pankajastro pankajastro deleted the add_more_tests branch October 18, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve code coverage
3 participants