ExternalTaskSensorAsync to support poke_interval #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 98.51% // Head: 98.51% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #823 +/- ##
=======================================
Coverage 98.51% 98.51%
=======================================
Files 87 87
Lines 4777 4780 +3
=======================================
+ Hits 4706 4709 +3
Misses 71 71
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rajaths010494
requested review from
phanikumv,
bharanidharan14,
pankajastro and
pankajkoti
as code owners
pankajastro
approved these changes
Dec 20, 2022
bharanidharan14
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recently started onboarding as the astronomer provider async sensors, I'm really appreciative you've made these available publicly!
One thing I noticed is that the FileSensorAsync supports poke_interval but the ExternalTaskSensorAsync does not and runs as a fixed 5 seconds. While this isn't an issue at the moment as we only run a few external task sensors as we scale up I wouldn't want 100s running every 5 seconds.
I notice that both DagStateTrigger and TaskStateTrigger support poll_interval.
closes #817