Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SnowflakeOperatorAsync XCom value to return #781

Merged
merged 4 commits into from
Nov 30, 2022

Conversation

bharanidharan14
Copy link
Contributor

Return an XCom of results in SnowflakeOperatorAsync as same as the sync version SnowflakeOperator

closes: #714

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 98.47% // Head: 98.48% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (5fc62f1) compared to base (dfea8e0).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 5fc62f1 differs from pull request most recent head 3cd854f. Consider uploading reports for the commit 3cd854f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #781   +/-   ##
=======================================
  Coverage   98.47%   98.48%           
=======================================
  Files          86       86           
  Lines        4663     4682   +19     
=======================================
+ Hits         4592     4611   +19     
  Misses         71       71           
Impacted Files Coverage Δ
astronomer/providers/snowflake/hooks/snowflake.py 98.73% <100.00%> (+0.32%) ⬆️
...ronomer/providers/snowflake/operators/snowflake.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bharanidharan14
Copy link
Contributor Author

Closed PR #752 created separate PR to return an XCom of results in SnowflakeOperatorAsync as same as the sync version SnowflakeOperator.

@bharanidharan14
Copy link
Contributor Author

@rajaths010494 @pankajkoti @phanikumv can you review this PR

@rajaths010494 rajaths010494 changed the title Fix SnowflakeOperatorAsync Xcom value to return Fix SnowflakeOperatorAsync XCom value to return Nov 28, 2022
@rajaths010494 rajaths010494 changed the title Fix SnowflakeOperatorAsync XCom value to return Fix SnowflakeOperatorAsync XCom value to return Nov 28, 2022
@rajaths010494 rajaths010494 changed the title Fix SnowflakeOperatorAsync XCom value to return Fix SnowflakeOperatorAsync XCom value to return Nov 28, 2022
@rajaths010494 rajaths010494 changed the title Fix SnowflakeOperatorAsync XCom value to return Fix SnowflakeOperatorAsync XCom value to return Nov 28, 2022
Copy link
Collaborator

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but have a question inline. Can we not remove that line to 'return None' ?

astronomer/providers/snowflake/operators/snowflake.py Outdated Show resolved Hide resolved
@bharanidharan14 bharanidharan14 force-pushed the snowflake-return-xcom-714 branch from bf9fe2c to 5fc62f1 Compare November 29, 2022 14:33
@pankajkoti pankajkoti force-pushed the snowflake-return-xcom-714 branch from 3cd854f to 5fc62f1 Compare November 30, 2022 08:12
@bharanidharan14 bharanidharan14 merged commit e006968 into main Nov 30, 2022
@bharanidharan14 bharanidharan14 deleted the snowflake-return-xcom-714 branch November 30, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operator XCOM - SnowflakeOperator
5 participants