-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SnowflakeOperatorAsync
XCom value to return
#781
Conversation
Codecov ReportBase: 98.47% // Head: 98.48% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #781 +/- ##
=======================================
Coverage 98.47% 98.48%
=======================================
Files 86 86
Lines 4663 4682 +19
=======================================
+ Hits 4592 4611 +19
Misses 71 71
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Closed PR #752 created separate PR to return an XCom of results in SnowflakeOperatorAsync as same as the sync version SnowflakeOperator. |
@rajaths010494 @pankajkoti @phanikumv can you review this PR |
SnowflakeOperatorAsync
XCom value to return
SnowflakeOperatorAsync
XCom value to returnSnowflakeOperatorAsync
XCom value to return
SnowflakeOperatorAsync
XCom value to returnSnowflakeOperatorAsync
XCom value to return
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but have a question inline. Can we not remove that line to 'return None' ?
bf9fe2c
to
5fc62f1
Compare
3cd854f
to
5fc62f1
Compare
Return an XCom of results in SnowflakeOperatorAsync as same as the sync version SnowflakeOperator
closes: #714