Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import error for snowflake extractor #607

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

pankajastro
Copy link
Contributor

look like >- in YAML put a space at the end for multiline string because of that import was failing in dev container for the snowflake extractor

closes: #606

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #607 (6e26655) into main (0ff239f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #607   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files          72       72           
  Lines        3975     3975           
=======================================
  Hits         3905     3905           
  Misses         70       70           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pankajkoti
Copy link
Collaborator

Does this approach work @pankajastro . Mean to ask with this does it no longer complain for import error and that both the extractors are loaded and run fine? I believe @rajaths010494 had checked previously with Maciej from GetInData and he had mentioned that this is an open issue on OL where multiple extractors load is failing for some reason.

@pankajastro
Copy link
Contributor Author

Does this approach work @pankajastro . Mean to ask with this does it no longer complain for import error and that both the extractors are loaded and run fine? I believe @rajaths010494 had checked previously with Maciej from GetInData and he had mentioned that this is an open issue on OL where multiple extractors load is failing for some reason

This more of looks like related YAML string parsing for example if I'm keeping the env like
OPENLINEAGE_EXTRACTORS: astronomer.providers.google.cloud.extractors.bigquery.BigQueryAsyncExtractor;astronomer.providers.snowflake.extractors.snowflake.SnowflakeAsyncExtractor i.e in a single like then it at least not complaining in UI.

Coming to your question, at least it not complaining in UI and also the error in not in the container. Do I need to do more testing like running some examples etc?
Screenshot 2022-08-23 at 11 43 54 AM

@pankajastro pankajastro merged commit 16f828f into main Aug 23, 2022
@pankajastro pankajastro deleted the fix_snowflake_extractor_module branch August 23, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the snowflake extractor import in dev docker
2 participants