Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Open lineage extractor for RedshiftAsync Operators #561

Merged
merged 9 commits into from
Sep 5, 2022

Conversation

rajaths010494
Copy link
Contributor

@rajaths010494 rajaths010494 commented Jul 28, 2022

Export query_ids as XCOM for the Redshift async operators
and add an OpenLineage custom extractor for the same.
Some additional OpenLineage specific environment variables
need to be set which are included as part of the
docker-compose.yaml file change in the commit.
Also adds unit tests for the custom extractor.

Closes #462

@rajaths010494 rajaths010494 changed the title Implement Open lineage extractor for RedshiftAsync Operators [WIP] Implement Open lineage extractor for RedshiftAsync Operators Jul 28, 2022
@codecov
Copy link

codecov bot commented Jul 28, 2022

Codecov Report

Merging #561 (f1c6f2d) into main (3f848d4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #561   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files          72       73    +1     
  Lines        3978     3994   +16     
=======================================
+ Hits         3908     3924   +16     
  Misses         70       70           
Impacted Files Coverage Δ
...onomer/providers/amazon/aws/extractors/redshift.py 100.00% <100.00%> (ø)
...er/providers/amazon/aws/operators/redshift_data.py 100.00% <100.00%> (ø)
...mer/providers/amazon/aws/operators/redshift_sql.py 96.42% <100.00%> (+0.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bharanidharan14
Copy link
Contributor

@pankajkoti @phanikumv @pankajastro I request you guys to review this PR even if it is in draft state, it helps to address the review comments faster

@rajaths010494 rajaths010494 changed the title [WIP] Implement Open lineage extractor for RedshiftAsync Operators Implement Open lineage extractor for RedshiftAsync Operators Aug 5, 2022
@rajaths010494 rajaths010494 force-pushed the ol-extractor-redshift branch from ef89243 to fe7fd0e Compare August 9, 2022 05:47
Copy link
Collaborator

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is something pending on this PR?

@rajaths010494 rajaths010494 force-pushed the ol-extractor-redshift branch from fe7fd0e to 8f23cd0 Compare August 12, 2022 08:32
@rajaths010494 rajaths010494 marked this pull request as ready for review August 17, 2022 08:57
@rajaths010494 rajaths010494 force-pushed the ol-extractor-redshift branch from 8f23cd0 to cd72d8d Compare August 17, 2022 08:57
@bharanidharan14
Copy link
Contributor

@rajaths010494 Is anything pending in this PR?

@rajaths010494
Copy link
Contributor Author

@rajaths010494 Is anything pending in this PR?

It is ready for review

@rajaths010494 rajaths010494 force-pushed the ol-extractor-redshift branch 2 times, most recently from 6ee2c9a to 3ce672b Compare August 19, 2022 07:06
@rajaths010494 rajaths010494 force-pushed the ol-extractor-redshift branch from 3ce672b to d186506 Compare August 25, 2022 12:10
@kaxil kaxil force-pushed the ol-extractor-redshift branch from c2a8c46 to f1c6f2d Compare September 2, 2022 10:50
Copy link
Collaborator

@pankajkoti pankajkoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Great work @rajaths010494

@rajaths010494 rajaths010494 merged commit 6b5c8fc into main Sep 5, 2022
@rajaths010494 rajaths010494 deleted the ol-extractor-redshift branch September 5, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement OpenLineage extractor for Redshift async operators
3 participants