-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Open lineage extractor for RedshiftAsync Operators #561
Conversation
Codecov Report
@@ Coverage Diff @@
## main #561 +/- ##
=======================================
Coverage 98.24% 98.24%
=======================================
Files 72 73 +1
Lines 3978 3994 +16
=======================================
+ Hits 3908 3924 +16
Misses 70 70
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@pankajkoti @phanikumv @pankajastro I request you guys to review this PR even if it is in draft state, it helps to address the review comments faster |
ef89243
to
fe7fd0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is something pending on this PR?
fe7fd0e
to
8f23cd0
Compare
8f23cd0
to
cd72d8d
Compare
@rajaths010494 Is anything pending in this PR? |
It is ready for review |
6ee2c9a
to
3ce672b
Compare
3ce672b
to
d186506
Compare
d186506
to
c2a8c46
Compare
c2a8c46
to
f1c6f2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Great work @rajaths010494
Export query_ids as XCOM for the Redshift async operators
and add an OpenLineage custom extractor for the same.
Some additional OpenLineage specific environment variables
need to be set which are included as part of the
docker-compose.yaml file change in the commit.
Also adds unit tests for the custom extractor.
Closes #462