-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Doc string for SnowflakeOperatorAsync #556
Conversation
305dcd7
to
94f1ddb
Compare
Codecov Report
@@ Coverage Diff @@
## main #556 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 72 72
Lines 3996 3996
=======================================
Hits 3927 3927
Misses 69 69
Continue to review full report at Codecov.
|
@phanikumv @rajaths010494 @pankajastro @pankajkoti, can you review this PR |
Can you please post the screenshot like how it is looking you can run |
LGTM , once Screenshot is added we can close. |
@rajaths010494 @pankajastro Added screenshot |
I can't see the below text in the screenshot but it is in the doc string. I was curious to see how it looks otherwise changes look good to me
|
a425bf1
to
5d51778
Compare
See also link is not visible in Docs, its not showing up in any of the operators/sensors |
then this is a bug in our documentation please create a ticket to track it. But I was able to do it in #464 |
Created Ticket |
dc29641
to
eaafd23
Compare
@phanikumv Addressed your PR review changes |
28feeb3
to
e819d86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor suggestions.
Update Doc string for SnowflakeOperatorAsync Update Doc string for SnowflakeOperatorAsync Doc fix Fix flake8 issue Doc string fix Doc fix
e819d86
to
b389902
Compare
@phanikumv Addressed your review comments, can you please review it again |
@phanikumv Need your approval |
Added Doc string for the SnowflakeOperatorAsync to get to know the use of this operator compared with snowflake sql API operator, best practices to be followed while using this operator and where can this
SnowflakeOperatorAsync
can be usedcloses: #557