Feat: SVector as common currency #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjebaker
added
the
integrator
fjebaker
added a commit
that referenced
this pull request
Aug 22, 2023
* test: remove standard array test * feat: export svectors * fix: use svector as common currency instead of tuple * chore: bump version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discontinue all support for regular (heap allocated) arrays as
uandv, as this not only makes the integration system convoluted, but is also entirely unused and a complete performance degredation even on GPUs (#8).This PR also brings #8 a step closer to being supported in main despite the poorer performance vs. multithreading.