Tetrad basis and various fixes #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjebaker
added
integrator
fjebaker
added a commit
that referenced
this pull request
Aug 22, 2023
* evaluate jacobian and value together * cache sin eval * calculate bounding box on converted mesh * improve bin transfer function api * fix gramm schmidt * fast math on metric components * allow different redshift functions to be used in cunningham * julia formatting * cleanup redshift function * bugfix * unit test for tetrad frame * bump version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the Gram-Schmidt implementation, which now correctly gives tetrad basis that reduces to Minkowski, so we can use it to map angles from local to global frame.
Also addresses #50 with a small fix.
Various other minor API changes and fixes, and more unit tests.