Refractive metric #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also closes #20 by using the correct metric components in the impact parameter mapping. |
fjebaker
added
enhancement
fjebaker
added a commit
that referenced
this pull request
Aug 22, 2023
* fixed impact parameter mapping in second order * added metric with refractive index * added exports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the BoyerLindquist + Refraction metric from Chainakun et al. (2022) with the AD backend.
There exists an issue with this 2nd order approach, namely that a direct discontinuity between the region of n > 1 and n = 1 means the AD has no gradient to compute, and the trajectories lose energy. To avoid this, I added an interpolated region which uses an arctan function to very closly mimic the shape of a step function, and provide a steep gradient along the corona membrane. This method keeps energy constant, and seems to yield good results.
Colouring by radial coordinate, a=1, n=1.1
which may be rendered as usual:
For a=1, n=0.95:
