Feat: improved transfer function branch splitting #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preferentially samples at approximately 1/3 and 2/3 of the domain. Could be useful for some edge cases.
Split branches off of pre-determined minima and maxima, therefore able to allocate the branches in full and decide on which is the upper and lower after they have been assembled. The sorted interpolation now also first sets gstar extrema to 0.0 and 1.0 to avoid any erroneous extrapolation. Toyed around with a few alternative methods for finding the extremal redshifts when calculating the transfer functions. Some loose end code in this commit solves using Optim for the extrema, however this is largely untested and therefore not yet used.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #104 +/- ##
==========================================
- Coverage 67.83% 67.08% -0.76%
==========================================
Files 53 53
Lines 1965 1993 +28
==========================================
+ Hits 1333 1337 +4
- Misses 632 656 +24
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fjebaker
added a commit
that referenced
this pull request
Aug 22, 2023
* feat: added cos image planes Preferentially samples at approximately 1/3 and 2/3 of the domain. Could be useful for some edge cases. * feat: improved branch split algorithm Split branches off of pre-determined minima and maxima, therefore able to allocate the branches in full and decide on which is the upper and lower after they have been assembled. The sorted interpolation now also first sets gstar extrema to 0.0 and 1.0 to avoid any erroneous extrapolation. Toyed around with a few alternative methods for finding the extremal redshifts when calculating the transfer functions. Some loose end code in this commit solves using Optim for the extrema, however this is largely untested and therefore not yet used. * chore: bump version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.