Initial Refactor #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Smoke tests added with a fairly coarse floating point comparisons. Since we're using We now smoke test:
At some point should add tests for the reverberation lag code, but I will wait until the API is a little more solid. Coverage: 43% |
|
Updated the DiscProfiles code and added test for the corona model sampling. Coverage: 56% |
|
Added redshift tests and fixed related bugs. Coverage: 63% |
fjebaker
added a commit
that referenced
this pull request
Aug 22, 2023
* minimally working * moved exports top level of each subdir * export all at module level * added common metrics * most work to date integrated * added missing deps * added CITATION, missing doi and date released * various bugfixes * some smoke tests and formatting * tolerance fix in tests * updated readme * typo corrections * bugfixes for disc profile tracing * added new version of disc profile code * lamp post model + domain & generators tests * typo fixes * fixed test tolerances * accretion formulae bugfixes * redshift pointfunction test * actually include tests in runner * punctuation fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined all of the previous repositories into one, excluding ComputedGeodesicEquations.jl, since it has been made redundant by the new AD methods.
Still to do before ready for a release to get the DOI for the project students: