Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merkle-maker + MerkleFeed mixin #178

Merged
merged 40 commits into from
Aug 7, 2024
Merged

Conversation

akhercha
Copy link
Member

@akhercha akhercha commented Jul 30, 2024

Closes #NA

Introduced changes

Pragma SDK

  • MerkleFeed mixin + simple tests
  • removed init_stats_contract and init correctly the stats contract like the other
  • re-added the update_abis poe command
  • Fixed pragma-sdk offchain requests - breaking change in our package, they need to be converted to string manually.

Pragma Oracle

  • Updated the branch to main ; was pointing a certain rev, not sure why

Merkle Maker

  • MerkleFeedPublisher class that handles the publishing onchain + to Redis,
  • Redis structure updated, see RedisManager docstring,
  • Fixed __hash__ not working,

@akhercha akhercha self-assigned this Jul 31, 2024
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 12 lines in your changes missing coverage. Please review.

Project coverage is 47.03%. Comparing base (3c7942a) to head (c7b3873).
Report is 25 commits behind head on master.

Files Patch % Lines
pragma-sdk/pragma_sdk/onchain/client.py 50.00% 4 Missing ⚠️
...ragma-sdk/pragma_sdk/onchain/mixins/merkle_feed.py 66.66% 4 Missing ⚠️
pragma-sdk/pragma_sdk/onchain/mixins/summary.py 60.00% 2 Missing ⚠️
.../common/fetchers/generic_fetchers/deribit/types.py 50.00% 1 Missing ⚠️
pragma-sdk/pragma_sdk/offchain/client.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #178       +/-   ##
===========================================
+ Coverage   16.12%   47.03%   +30.90%     
===========================================
  Files           6       63       +57     
  Lines          62     3121     +3059     
===========================================
+ Hits           10     1468     +1458     
- Misses         52     1653     +1601     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akhercha akhercha requested a review from EvolveArt August 1, 2024 13:15
@akhercha
Copy link
Member Author

akhercha commented Aug 3, 2024

@EvolveArt I made some significant changes in the merkle-maker repo, need a new review sir

@akhercha akhercha changed the title feat: MerkleFeed mixin feat: merkle-maker + MerkleFeed mixin Aug 3, 2024
Copy link
Contributor

@EvolveArt EvolveArt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

merkle-maker/merkle_maker/publisher.py Show resolved Hide resolved
merkle-maker/merkle_maker/redis.py Outdated Show resolved Hide resolved
merkle-maker/merkle_maker/publisher.py Outdated Show resolved Hide resolved
@EvolveArt EvolveArt merged commit f4003aa into master Aug 7, 2024
11 of 12 checks passed
@EvolveArt EvolveArt deleted the feat/merkle_feed_mixin branch August 7, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants