feat: Chainlink interface #94
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gas Report SummarySpotMedian
TWAP
RealizedVolatility
Options
Perpetuals
|
1 similar comment
Gas Report SummarySpotMedian
TWAP
RealizedVolatility
Options
Perpetuals
|
Gas Report SummarySpotMedian
TWAP
RealizedVolatility
Options
Perpetuals
|
1 similar comment
Gas Report SummarySpotMedian
TWAP
RealizedVolatility
Options
Perpetuals
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * Users should deploy an instance of this contract to wrap every price feed id that they need to use. | ||
| */ | ||
| contract PragmaAggregatorV3 { | ||
| bytes32 public feedId; |
Check warning
Code scanning / Slither
State variables that could be declared immutable
| */ | ||
| contract PragmaAggregatorV3 { | ||
| bytes32 public feedId; | ||
| IPragma public pragmaInterface; |
Check warning
Code scanning / Slither
State variables that could be declared immutable
Comment on lines
24
to
32
| function updateFeeds(bytes[] calldata priceUpdateData) public payable { | ||
| // Update the prices to the latest available values and pay the required fee for it. The `priceUpdateData` data | ||
| // should be retrieved from the Theoros SDK, you can find additional information on https://docs.pragmaoracle.com/ | ||
| uint256 fee = pragmaInterface.getUpdateFee(priceUpdateData); | ||
| pragmaInterface.updateDataFeeds{value: fee}(priceUpdateData); | ||
|
|
||
| // refund remaining eth | ||
| payable(msg.sender).call{value: address(this).balance}(""); | ||
| } |
Check failure
Code scanning / Slither
Functions that send Ether to arbitrary destinations
Gas Report SummarySpotMedian
TWAP
RealizedVolatility
Options
Perpetuals
|
1 similar comment
Gas Report SummarySpotMedian
TWAP
RealizedVolatility
Options
Perpetuals
|
Gas Report SummarySpotMedian
TWAP
RealizedVolatility
Options
Perpetuals
|
Gas Report SummarySpotMedian
TWAP
RealizedVolatility
Options
Perpetuals
|
Gas Report SummarySpotMedian
TWAP
RealizedVolatility
Options
Perpetuals
|
1 similar comment
Gas Report SummarySpotMedian
TWAP
RealizedVolatility
Options
Perpetuals
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #76
Addition