Issue: Fix Integration test test_mailbox_evm_to_strk #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsandinoDev
changed the title
|
Hey, apparently the integration tests fail. Furthermore, we might not want to verify a mesage inside the deployment section. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the current integration tests that stop working after the the refactor of the contracts in this commit 6ef5aa2
Solve issue: #26
Bytes,Messagefrom multisig_ism.deploy_multisigby replacing the.setValidatorsand calling theverify(&metadata, &message)at the end of the test.send_msg_strk_to_evmby adding the missing paramter ofmailbox,dispatch. Err [E0599].