Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat deployment scripts #2

Merged
merged 19 commits into from
Aug 26, 2024
Merged

Feat deployment scripts #2

merged 19 commits into from
Aug 26, 2024

Conversation

JordyRo1
Copy link
Contributor

@JordyRo1 JordyRo1 commented Jul 30, 2024 •
edited
Loading

Resolves #1

Additions

  • Deployments scripts (first draft)

TODO:

  • Fix code panicking during the declaration process
  • Improve code general organization
  • Fix the invalid nonce issue

@JordyRo1 JordyRo1 requested a review from EvolveArt July 30, 2024 21:18
@JordyRo1 JordyRo1 marked this pull request as draft July 30, 2024 21:18
EvolveArt
EvolveArt requested changes Jul 30, 2024
View reviewed changes
Copy link

@EvolveArt EvolveArt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably create cainome bindings for the contracts as we did for hyperlane, pretty easy and will make everything cleaner and safer

scripts/src/deploy.rs Outdated Show resolved Hide resolved
scripts/src/deploy.rs Outdated Show resolved Hide resolved
scripts/src/deploy.rs Outdated Show resolved Hide resolved
scripts/src/deploy.rs Outdated Show resolved Hide resolved
@JordyRo1 JordyRo1 marked this pull request as ready for review August 1, 2024 08:47
@EvolveArt EvolveArt merged commit b4711a8 into main Aug 26, 2024
2 checks passed
@EvolveArt EvolveArt deleted the Feat-Deployment-scripts branch August 26, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvolveArt EvolveArt EvolveArt requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dev: deployment scripts
2 participants
@JordyRo1 @EvolveArt