Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent colon usage in build failure errors #8994

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Consistent colon usage in build failure errors #8994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/uv-requirements/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@ pub mod upgrade;

#[derive(Debug, thiserror::Error)]
pub enum Error {
#[error("Failed to download: `{0}`")]
#[error("Failed to download `{0}`")]
Download(BuiltDist, #[source] uv_distribution::Error),

#[error("Failed to download and build: `{0}`")]
#[error("Failed to download and build `{0}`")]
DownloadAndBuild(SourceDist, #[source] uv_distribution::Error),

#[error("Failed to build: `{0}`")]
#[error("Failed to build `{0}`")]
Build(SourceDist, #[source] uv_distribution::Error),

#[error(transparent)]
Expand Down
2 changes: 1 addition & 1 deletion crates/uv/tests/it/export.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,7 +624,7 @@ fn frozen() -> Result<()> {
----- stdout -----

----- stderr -----
error: Failed to build: `project @ file://[TEMP_DIR]/`
error: Failed to build `project @ file://[TEMP_DIR]/`
Caused by: Failed to parse entry: `child`
Caused by: Package is not included as workspace package in `tool.uv.workspace`
"###);
Expand Down
14 changes: 7 additions & 7 deletions crates/uv/tests/it/lock.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9439,7 +9439,7 @@ fn lock_mismatched_sources() -> Result<()> {
----- stdout -----

----- stderr -----
error: Failed to build: `project @ file://[TEMP_DIR]/`
error: Failed to build `project @ file://[TEMP_DIR]/`
Caused by: Failed to parse entry: `uv-public-pypackage`
Caused by: Can't combine URLs from both `project.dependencies` and `tool.uv.sources`
"###);
Expand Down Expand Up @@ -13605,7 +13605,7 @@ fn lock_named_index_cli() -> Result<()> {
----- stdout -----

----- stderr -----
error: Failed to build: `project @ file://[TEMP_DIR]/`
error: Failed to build `project @ file://[TEMP_DIR]/`
Caused by: Failed to parse entry: `jinja2`
Caused by: Package `jinja2` references an undeclared index: `pytorch`
"###);
Expand Down Expand Up @@ -15671,7 +15671,7 @@ fn lock_invalid_project_table() -> Result<()> {

----- stderr -----
Using CPython 3.12.[X] interpreter at: [PYTHON-3.12]
error: Failed to build: `b @ file://[TEMP_DIR]/b`
error: Failed to build `b @ file://[TEMP_DIR]/b`
Caused by: Failed to extract static metadata from `pyproject.toml`
Caused by: `pyproject.toml` is using the `[project]` table, but the required `project.name` field is not set.
Caused by: TOML parse error at line 2, column 10
Expand Down Expand Up @@ -17295,7 +17295,7 @@ fn lock_group_include_cycle() -> Result<()> {
----- stdout -----

----- stderr -----
error: Failed to build: `project @ file://[TEMP_DIR]/`
error: Failed to build `project @ file://[TEMP_DIR]/`
Caused by: Detected a cycle in `dependency-groups`: `bar` -> `foobar` -> `foo` -> `bar`
"###);

Expand Down Expand Up @@ -17326,7 +17326,7 @@ fn lock_group_include_missing() -> Result<()> {
----- stdout -----

----- stderr -----
error: Failed to build: `project @ file://[TEMP_DIR]/`
error: Failed to build `project @ file://[TEMP_DIR]/`
Caused by: Failed to find group `bar` included by `foo`
"###);

Expand Down Expand Up @@ -17357,7 +17357,7 @@ fn lock_group_invalid_entry_package() -> Result<()> {
----- stdout -----

----- stderr -----
error: Failed to build: `project @ file://[TEMP_DIR]/`
error: Failed to build `project @ file://[TEMP_DIR]/`
Caused by: Failed to parse entry in group `foo`: `invalid!`
Caused by: no such comparison operator "!", must be one of ~= == != <= >= < > ===
invalid!
Expand All @@ -17370,7 +17370,7 @@ fn lock_group_invalid_entry_package() -> Result<()> {
----- stdout -----

----- stderr -----
error: Failed to build: `project @ file://[TEMP_DIR]/`
error: Failed to build `project @ file://[TEMP_DIR]/`
Caused by: Failed to parse entry in group `foo`: `invalid!`
Caused by: no such comparison operator "!", must be one of ~= == != <= >= < > ===
invalid!
Expand Down
8 changes: 4 additions & 4 deletions crates/uv/tests/it/pip_compile.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1875,7 +1875,7 @@ fn compile_git_mismatched_name() -> Result<()> {
----- stdout -----

----- stderr -----
error: Failed to download and build: `dask @ git+https://github.com/pallets/[email protected]`
error: Failed to download and build `dask @ git+https://github.com/pallets/[email protected]`
Caused by: Package metadata name `flask` does not match given name `dask`
"###
);
Expand Down Expand Up @@ -5915,7 +5915,7 @@ fn offline_direct_url() -> Result<()> {
----- stdout -----

----- stderr -----
error: Failed to download: `iniconfig @ https://files.pythonhosted.org/packages/ef/a6/62565a6e1cf69e10f5727360368e451d4b7f58beeac6173dc9db836a5b46/iniconfig-2.0.0-py3-none-any.whl`
error: Failed to download `iniconfig @ https://files.pythonhosted.org/packages/ef/a6/62565a6e1cf69e10f5727360368e451d4b7f58beeac6173dc9db836a5b46/iniconfig-2.0.0-py3-none-any.whl`
Caused by: Network connectivity is disabled, but the requested data wasn't found in the cache for: `https://files.pythonhosted.org/packages/ef/a6/62565a6e1cf69e10f5727360368e451d4b7f58beeac6173dc9db836a5b46/iniconfig-2.0.0-py3-none-any.whl`
"###
);
Expand Down Expand Up @@ -9961,7 +9961,7 @@ fn not_found_direct_url() -> Result<()> {
----- stdout -----

----- stderr -----
error: Failed to download: `iniconfig @ https://files.pythonhosted.org/packages/ef/a6/fake/iniconfig-2.0.0-py3-none-any.whl`
error: Failed to download `iniconfig @ https://files.pythonhosted.org/packages/ef/a6/fake/iniconfig-2.0.0-py3-none-any.whl`
Caused by: Failed to fetch: `https://files.pythonhosted.org/packages/ef/a6/fake/iniconfig-2.0.0-py3-none-any.whl`
Caused by: HTTP status client error (404 Not Found) for url (https://files.pythonhosted.org/packages/ef/a6/fake/iniconfig-2.0.0-py3-none-any.whl)
"###
Expand Down Expand Up @@ -12021,7 +12021,7 @@ fn git_source_missing_tag() -> Result<()> {
----- stdout -----

----- stderr -----
error: Failed to download and build: `uv-public-pypackage @ git+https://github.com/astral-test/uv-public-pypackage@missing`
error: Failed to download and build `uv-public-pypackage @ git+https://github.com/astral-test/uv-public-pypackage@missing`
Caused by: Git operation failed
Caused by: failed to clone into: [CACHE_DIR]/git-v0/db/8dab139913c4b566
Caused by: failed to fetch tag `missing`
Expand Down
14 changes: 7 additions & 7 deletions crates/uv/tests/it/pip_install.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ dependencies = ["flask==1.0.x"]
----- stdout -----

----- stderr -----
error: Failed to build: `project @ file://[TEMP_DIR]/path_dep`
error: Failed to build `project @ file://[TEMP_DIR]/path_dep`
Caused by: Build backend failed to determine requirements with `build_wheel()` (exit status: 1)

[stdout]
Expand Down Expand Up @@ -1627,7 +1627,7 @@ fn install_git_public_https_missing_branch_or_tag() {
----- stdout -----

----- stderr -----
error: Failed to download and build: `uv-public-pypackage @ git+https://github.com/astral-test/[email protected]`
error: Failed to download and build `uv-public-pypackage @ git+https://github.com/astral-test/[email protected]`
Caused by: Git operation failed
Caused by: failed to clone into: [CACHE_DIR]/git-v0/db/8dab139913c4b566
Caused by: failed to fetch branch or tag `2.0.0`
Expand Down Expand Up @@ -1664,7 +1664,7 @@ fn install_git_public_https_missing_commit() {
----- stdout -----

----- stderr -----
error: Failed to download and build: `uv-public-pypackage @ git+https://github.com/astral-test/uv-public-pypackage@79a935a7a1a0ad6d0bdf72dce0e16cb0a24a1b3b`
error: Failed to download and build `uv-public-pypackage @ git+https://github.com/astral-test/uv-public-pypackage@79a935a7a1a0ad6d0bdf72dce0e16cb0a24a1b3b`
Caused by: Git operation failed
Caused by: failed to clone into: [CACHE_DIR]/git-v0/db/8dab139913c4b566
Caused by: failed to fetch commit `79a935a7a1a0ad6d0bdf72dce0e16cb0a24a1b3b`
Expand Down Expand Up @@ -1876,7 +1876,7 @@ fn install_git_private_https_pat_not_authorized() {
----- stdout -----

----- stderr -----
error: Failed to download and build: `uv-private-pypackage @ git+https://git:***@github.com/astral-test/uv-private-pypackage`
error: Failed to download and build `uv-private-pypackage @ git+https://git:***@github.com/astral-test/uv-private-pypackage`
Caused by: Git operation failed
Caused by: failed to clone into: [CACHE_DIR]/git-v0/db/8401f5508e3e612d
Caused by: process didn't exit successfully: `git fetch --force --update-head-ok 'https://git:***@github.com/astral-test/uv-private-pypackage' '+HEAD:refs/remotes/origin/HEAD'` (exit status: 128)
Expand Down Expand Up @@ -4015,7 +4015,7 @@ fn no_build_isolation() -> Result<()> {
----- stdout -----

----- stderr -----
error: Failed to download and build: `anyio @ https://files.pythonhosted.org/packages/db/4d/3970183622f0330d3c23d9b8a5f52e365e50381fd484d08e3285104333d3/anyio-4.3.0.tar.gz`
error: Failed to download and build `anyio @ https://files.pythonhosted.org/packages/db/4d/3970183622f0330d3c23d9b8a5f52e365e50381fd484d08e3285104333d3/anyio-4.3.0.tar.gz`
Caused by: Build backend failed to determine metadata through `prepare_metadata_for_build_wheel` (exit status: 1)

[stderr]
Expand Down Expand Up @@ -4084,7 +4084,7 @@ fn respect_no_build_isolation_env_var() -> Result<()> {
----- stdout -----

----- stderr -----
error: Failed to download and build: `anyio @ https://files.pythonhosted.org/packages/db/4d/3970183622f0330d3c23d9b8a5f52e365e50381fd484d08e3285104333d3/anyio-4.3.0.tar.gz`
error: Failed to download and build `anyio @ https://files.pythonhosted.org/packages/db/4d/3970183622f0330d3c23d9b8a5f52e365e50381fd484d08e3285104333d3/anyio-4.3.0.tar.gz`
Caused by: Build backend failed to determine metadata through `prepare_metadata_for_build_wheel` (exit status: 1)

[stderr]
Expand Down Expand Up @@ -7045,7 +7045,7 @@ fn install_build_isolation_package() -> Result<()> {
----- stdout -----

----- stderr -----
error: Failed to download and build: `iniconfig @ https://files.pythonhosted.org/packages/d7/4b/cbd8e699e64a6f16ca3a8220661b5f83792b3017d0f79807cb8708d33913/iniconfig-2.0.0.tar.gz`
error: Failed to download and build `iniconfig @ https://files.pythonhosted.org/packages/d7/4b/cbd8e699e64a6f16ca3a8220661b5f83792b3017d0f79807cb8708d33913/iniconfig-2.0.0.tar.gz`
Caused by: Build backend failed to determine metadata through `prepare_metadata_for_build_wheel` (exit status: 1)

[stderr]
Expand Down
2 changes: 1 addition & 1 deletion crates/uv/tests/it/workspace.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1695,7 +1695,7 @@ fn workspace_member_name_shadows_dependencies() -> Result<()> {

----- stderr -----
Using CPython 3.12.[X] interpreter at: [PYTHON-3.12]
error: Failed to build: `foo @ file://[TEMP_DIR]/workspace/packages/foo`
error: Failed to build `foo @ file://[TEMP_DIR]/workspace/packages/foo`
Caused by: Failed to parse entry: `anyio`
Caused by: Package is not included as workspace package in `tool.uv.workspace`
"###
Expand Down
Loading