Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(dependency-bots): mention PEP 723 + some improvements #7819

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

mkniewallner
Copy link
Contributor

@mkniewallner mkniewallner commented Sep 30, 2024

Summary

Renovate recently gained support for updating dependencies defined using PEP 723 (renovatebot/renovate#31266). Since uv supports this format, I thought it could be nice to mention support for it in the integrations documentation as well. I took the occasion to make the page a bit more structured as well.

Test Plan

Ran Renovate on https://github.com/mkniewallner/renovate-pep723, which created mkniewallner/renovate-pep723#2 that updates a dependency defined using PEP 723. But I'll re-run some tests again once the changes are released on Renovate cloud GitHub app just in case.

@zanieb zanieb added the documentation Improvements or additions to documentation label Sep 30, 2024
@zanieb
Copy link
Member

zanieb commented Sep 30, 2024

Thanks!

@mkniewallner mkniewallner marked this pull request as ready for review October 9, 2024 16:21
@mkniewallner
Copy link
Contributor Author

mkniewallner commented Oct 9, 2024

Renovate version has been updated in the cloud app today. Just in case, tested the feature on the app and it works as expected: mkniewallner/renovate-pep723#4, so this should be ready to merge.

@zanieb zanieb merged commit c2f13f9 into astral-sh:main Oct 9, 2024
50 checks passed
@mkniewallner mkniewallner deleted the docs/update-dependency-bots branch October 9, 2024 16:26
Comment on lines -19 to +32
```json5 title="renovate.json5"
```jsx title="renovate.json5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the change to jsx here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

json5 did not actually highlight the code as JSON5 in mkdocs, but jsx did when testing locally. Not in front of a computer right now so I can't send a screenshot unfortunately, but it should be testable locally.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • json5:

Screenshot From 2024-10-09 21-10-28

  • jsx:

Screenshot From 2024-10-09 21-10-36

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants