Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(concepts): mention PEP 625 #7189

Merged

Conversation

mkniewallner
Copy link
Contributor

Summary

Follow-up to #7168 (comment).

Comment on lines 301 to 303
[PEP 625](https://peps.python.org/pep-0625/) specifies that packages must distribute source
distributions as gzip tarball (`.tar.gz`) archives. As before this PEP, other formats were also
allowed, uv supports reading and extracting archives that use the following formats:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[PEP 625](https://peps.python.org/pep-0625/) specifies that packages must distribute source
distributions as gzip tarball (`.tar.gz`) archives. As before this PEP, other formats were also
allowed, uv supports reading and extracting archives that use the following formats:
[PEP 625](https://peps.python.org/pep-0625/) specifies that packages must distribute source
distributions as gzip tarball (`.tar.gz`) archives. Prior to this specification, other archive formats
were allowed so uv also supports reading and extracting archives in the following formats:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops sorry, I force-pushed before your review, since it was still in draft (damn you're fast! 😄). Will incorporate your suggestions though, thanks!

@mkniewallner mkniewallner force-pushed the docs/follow-up-source-distribution branch from 6c45f4b to 548ada6 Compare September 8, 2024 15:02
Co-authored-by: Zanie Blue <[email protected]>
@mkniewallner mkniewallner marked this pull request as ready for review September 8, 2024 15:15
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@charliermarsh charliermarsh added the documentation Improvements or additions to documentation label Sep 8, 2024
@charliermarsh charliermarsh merged commit eec5403 into astral-sh:main Sep 8, 2024
47 checks passed
@mkniewallner mkniewallner deleted the docs/follow-up-source-distribution branch September 8, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants