Allow system interpreters set by VIRTUAL_ENV to be used without opt-in
#4018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tem" interpreter
zanieb
changed the title
VIRTUAL_ENV as explicit selection of a "system" interpreterVIRTUAL_ENV
zanieb
changed the title
VIRTUAL_ENVVIRTUAL_ENV to be used without opt-in
|
I'm a little hesitant here, but it seems common enough to allow it? |
|
I thought this included #4009 but it actually doesn't resolve that. I'm leaning towards waiting on this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3905
Allows an active virtual environment to be used even if it's not PEP 405 compliant (unless
SystemPython::Disallowedis passed; which I don't think we ever do right now in user-facing code). User reports indicate that PEP 405 compliance may be too high of a bar. We will emit a debug log noting this, but otherwise not warn — we may want a more user-facing warning.