Update bundled Python URLs and add "arm" architecture variant
#3855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
added
the
internal
charliermarsh
commented
May 27, 2024
| @@ -131,7 +131,7 @@ impl FromStr for Arch { | |||
| match s.to_lowercase().as_str() { | |||
| "aarch64" | "arm64" => Ok(Self::Aarch64), | |||
| "armv6l" => Ok(Self::Armv6L), | |||
| "armv7l" => Ok(Self::Armv7L), | |||
| "armv7l" | "arm" => Ok(Self::Armv7L), | |||
There was a problem hiding this comment.
This needs to be revisited more holistically; I'm just trying to fix the failure on ARM for now. But, anyway, Rust's std::env::consts::ARCH just returns "arm", whereas we need to differentiate between ARM v6 and ARM v7 I guess? I'm also not sure whether the enum variants are intended to match some Rust or Python convention somewhere.This needs to be revisited more holistically; I'm just trying to fix the failure on ARM for now. But, anyway, Rust's std::env::consts::ARCH just returns "arm", whereas we need to differentiate between ARM v6 and ARM v7 I guess? I'm also not sure whether the enum variants are intended to match some Rust or Python convention somewhere.
charliermarsh
added
bug
charliermarsh
changed the title
"arm" architecture variant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This also adds filtering for the ARM Pythons, since that needs some libc changes; and it closes #3854 by way of adding an "arm" branch.