-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for retrieving credentials from keyring
#2254
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
7193418
Basic implementation of keyring support
BakerNet f42ed8f
Better argument description
BakerNet 82dd007
move keyring auth to middleware
BakerNet c7ee0b0
clippy
BakerNet 0294317
Use lazy_static for memoization
BakerNet d785d55
more unit tests
BakerNet f791d71
typo
BakerNet 62393d5
clippy
BakerNet efd0a18
Review changs Round 1
BakerNet d9be41d
Review changes Round 1.1
BakerNet bac29c1
clippy
BakerNet 54f8c8a
AuthenticationStore progress
BakerNet 32b2e35
AuthenticationStore completed
BakerNet 5b1dd56
Merge with master
BakerNet cea115e
Clippy
BakerNet 39bcb7a
Merge remote-tracking branch 'upstream/main' into feature/basic-use-k…
BakerNet cdbea4e
Update to use Middleware instead of RequestInitializer
BakerNet ea63122
Use keyring-provider to match pip interface
BakerNet 803ad1a
fmt
BakerNet 6123dfd
Change set_from_url
BakerNet 177bdee
Merge remote-tracking branch 'upstream/main' into feature/basic-use-k…
BakerNet ba488bc
support UV_KEYRING_SUBPROCESS env var
75dc306
Merge remote-tracking branch 'upstream/main' into feature/basic-use-k…
BakerNet 1594462
Merge pull request #1 from thomasgilgenast/keyring
BakerNet 36d43f0
Update crates/uv-auth/src/store.rs
BakerNet 5fff276
Review Round 2
BakerNet fd05e73
Docstring
BakerNet 2cf1094
Warn on keyring error
BakerNet 984fd59
Merge branch 'main' into feature/basic-use-keyring
BakerNet 322b09e
Review Round 3
BakerNet b281499
Merge remote-tracking branch 'upstream/main' into feature/basic-use-k…
BakerNet 93d8b30
wiremock bump to avoid dependancy mismatch
BakerNet 31cd4e4
Merge remote-tracking branch 'upstream/main' into feature/basic-use-k…
BakerNet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the assumption here is that we've already hit the base URL on a previous invocation of the middleware, and so its credentials are already stored in the
AuthenticationStore
, and will be propagated here if needed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that was my assumption. That if
base
has auth, it received it from a copy from a previous request (inFlatIndexClient.read_from_url
orRegistryClient.simple_single_index
).