don't use the Cool popup-generating eprintln in trampoline for warnings #11295
Conversation
Also I refactored the code a bit to centralize all the calls of eprintln.
|
Oh right I need to like... regenerate these binaries... |
|
Drafting until binaries uploaded |
|
@zanieb slated to upload binaries (not building on my mac right now) |
|
Confirmed popups no more |
| @@ -509,6 +499,12 @@ pub fn bounce(is_gui: bool) -> ! { | |||
| exit_with_status(exit_code); | |||
| } | |||
|
|
|||
| #[cold] | |||
| fn error_and_exit(message: &str) -> ! { | |||
There was a problem hiding this comment.
nit: would prefer like exit_with_error?
There was a problem hiding this comment.
I guess probably not worth the regen
There was a problem hiding this comment.
(unless needed to test #11295 (comment))
| error!("{}", message); | ||
| exit_with_status(1); |
There was a problem hiding this comment.
Does this pop-up persist beyond the program exiting? Or block exit until it's ack'd?
There was a problem hiding this comment.
popup blocks exit (or maybe startup? my example was too trivial to distinguish that) yeah.
There was a problem hiding this comment.
I guess in the error cases that's not even a real distinction (it's a meaningful distinction with warnings, but none of those popup anymore so not a distinction anymore :)
There was a problem hiding this comment.
genuinely unsure how to trigger an error popup here. as you said before most of them are "uv is broken, wtf" errors
There was a problem hiding this comment.
I think you'd have to just like if true then throw the pop-up to see if it works as intended. Not a big deal, was just wondering if these would actually be visible as intended.
There was a problem hiding this comment.
good point. confirmed it blocks the process from exiting until the popup is dismissed, so you see it.
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [astral-sh/uv](https://github.com/astral-sh/uv) | patch | `0.5.29` -> `0.5.30` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>astral-sh/uv (astral-sh/uv)</summary> ### [`v0.5.30`](https://github.com/astral-sh/uv/blob/HEAD/CHANGELOG.md#0530) [Compare Source](astral-sh/uv@0.5.29...0.5.30) ##### Python The managed PyPy distributions have been updated for PyPy v7.3.18, which includes: - PyPy3.10, which updates the standard library from Python 3.10.14 to 3.10.19 - PyPy3.11, which adds beta support for Python 3.11.11 See the [PyPy release](https://pypy.org/posts/2025/02/pypy-v7318-release.html) for more details. ##### Enhancements - Add `uv sync --dry-run` ([#​11299](astral-sh/uv#11299)) - Ignore `#egg` fragment in HTML Simple API response ([#​11340](astral-sh/uv#11340)) ##### Configuration - Add `NO_BINARY` and `NO_BINARY_PACKAGE` environment variables ([#​11399](astral-sh/uv#11399)) ##### Performance - Avoid re-cloning name when populating ambiguous set ([#​11401](astral-sh/uv#11401)) - Optimize flattening in large workspaces ([#​11313](astral-sh/uv#11313)) ##### Bug fixes - Allow dynamic packages to be overloaded ([#​11400](astral-sh/uv#11400)) - Fix credential caching for index roots when URL ends in `simple/` ([#​11336](astral-sh/uv#11336)) - Fix marker merging for requirements.txt for psycopg ([#​11298](astral-sh/uv#11298)) - Set 777 permissions on locked files ([#​11328](astral-sh/uv#11328)) - Support extras in `@` requests for tools ([#​11335](astral-sh/uv#11335)) - Upgrade `astral-tokio-tar` to v0.5.1 ([#​11359](astral-sh/uv#11359)) - Avoid missing logging for no-op upgrade events ([#​11301](astral-sh/uv#11301)) - Use refined specifiers when logging narrowed Python range ([#​11334](astral-sh/uv#11334)) - Don't use popup-generating `eprintln` in trampoline warnings ([#​11295](astral-sh/uv#11295)) - Patch pkg-config files to be relocatable ([#​11291](astral-sh/uv#11291)) - Fix a case of duplicate `torch` packages when using conflicting extras ([#​11323](astral-sh/uv#11323)) ##### Documentation - Add docs for `uv tool install --editable` ([#​11280](astral-sh/uv#11280)) - Fix broken anchors in README and docs index ([#​11338](astral-sh/uv#11338)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNjQuMSIsInVwZGF0ZWRJblZlciI6IjM5LjE2NC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Also I refactored the code a bit to centralize all the calls of eprintln.
Fixes #10706