Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sources paths should be platform-agnostic #7493

Closed
SnirShechter opened this issue Sep 18, 2024 · 1 comment · Fixed by #7504
Closed

Sources paths should be platform-agnostic #7493

SnirShechter opened this issue Sep 18, 2024 · 1 comment · Fixed by #7504
Assignees
@charliermarsh
Labels
bug Something isn't working windows Specific to the Windows platform

Comments

@SnirShechter
Copy link

Running uv add <path> on Windows adds the sources path with backslash () Windows-style, which causes it to fail when running on other platforms.

Manually changing to slash (/) makes it work on all platforms.

uv add <path> should always use slash (/).
@charliermarsh charliermarsh added the windows Specific to the Windows platform label Sep 18, 2024
@charliermarsh
Copy link
Member

Agreed, I assumed we did this already.

@charliermarsh charliermarsh added the bug Something isn't working label Sep 18, 2024
@charliermarsh charliermarsh self-assigned this Sep 18, 2024
@charliermarsh charliermarsh mentioned this issue Sep 18, 2024
Merged
charliermarsh added a commit that referenced this issue Sep 18, 2024
@charliermarsh
Use portable paths when serializing sources (#7504)
e36cc99 
## Summary

Closes #7493.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charliermarsh charliermarsh

Labels
bug Something isn't working windows Specific to the Windows platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use portable paths when serializing sources astral-sh/uv
2 participants
@charliermarsh @SnirShechter