Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dependencies into git workspaces #4920

Closed
konstin opened this issue Jul 9, 2024 · 0 comments · Fixed by #8665
Closed

Support dependencies into git workspaces #4920

konstin opened this issue Jul 9, 2024 · 0 comments · Fixed by #8665
Labels
bug Something isn't working help wanted Contribution especially encouraged

Comments

@konstin
Copy link
Member

konstin commented Jul 9, 2024

Say we have our local workspace with a package a, and another workspace in a git repository with c and d. We have a -> c, c -> d. Currently, this fails by resolving c to the git repository but d to pypi.

To reproduce:

[project]
name = "a"
version = "0.1.0"
requires-python = ">=3.12"
dependencies = ["c"]

[tool.uv.sources]
c = { git = "https://github.com/konstin/workspace-git-path-dep-test", subdirectory = "packages/c" }

https://github.com/konstin/workspace-git-path-dep-test contains the packages c and d.

@konstin konstin added bug Something isn't working preview Experimental behavior labels Jul 9, 2024
@konstin konstin moved this to Backlog in uv: release-ready Jul 9, 2024
@konstin konstin added the help wanted Contribution especially encouraged label Jul 9, 2024
@zanieb zanieb removed the preview Experimental behavior label Aug 20, 2024
konstin added a commit that referenced this issue Oct 29, 2024
When resolving workspace dependencies from a workspace that's in git, we need to convert these transitive dependencies to git dependencies. This fixes a bug where we would treat them as path dependencies inside the checkout directory, leading either to clashes (between a local path and another direct git dependency) or invalid lockfiles (referencing the checkout dir).

Fixes #8087
Fixes #4920
Fixes #3936 since we needed that information anyway
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Contribution especially encouraged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants