Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow different locals in forks #4580

Closed
konstin opened this issue Jun 27, 2024 · 0 comments · Fixed by #5104
Closed

Allow different locals in forks #4580

konstin opened this issue Jun 27, 2024 · 0 comments · Fixed by #5104
Assignees
@ibraheemdev
Labels
lock Related to universal resolution and locking preview Experimental behavior

Comments

@konstin
Copy link
Member

konstin commented Jun 27, 2024

As we allow different URLs in forks, we should also split the locals settings by fork.
@konstin konstin added the preview Experimental behavior label Jun 27, 2024
@konstin konstin mentioned this issue Jun 27, 2024
Closed
@zanieb zanieb added the lock Related to universal resolution and locking label Jun 27, 2024
@konstin konstin mentioned this issue Jul 8, 2024
Closed
@konstin konstin moved this to Backlog in uv: release-ready Jul 9, 2024
@ibraheemdev ibraheemdev self-assigned this Jul 12, 2024
@ibraheemdev ibraheemdev mentioned this issue Jul 16, 2024
Merged
ibraheemdev added a commit that referenced this issue Jul 16, 2024
@ibraheemdev
Allow conflicting locals when forking (#5104)
d583847 
## Summary

Currently, the `Locals` type relies on there being a single local
version for a given package. With marker expressions this may not be
true, a similar problem to #4435.
This changes the `Locals` type to `ForkLocals`, which tracks locals for
a given fork. Local versions are now tracked on `PubGrubRequirement`
before forking.

Resolves #4580.
@github-project-automation github-project-automation bot moved this from Backlog to Done in uv: release-ready Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibraheemdev ibraheemdev

Labels
lock Related to universal resolution and locking preview Experimental behavior
Projects
No open projects
uv: release-ready
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow conflicting locals when forking astral-sh/uv
3 participants
@zanieb @konstin @ibraheemdev