Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 514 support #1521

Closed
zanieb opened this issue Feb 16, 2024 · 2 comments · Fixed by #6761
Closed

PEP 514 support #1521

zanieb opened this issue Feb 16, 2024 · 2 comments · Fixed by #6761
Labels
help wanted Contribution especially encouraged windows Specific to the Windows platform

Comments

@zanieb
Copy link
Member

zanieb commented Feb 16, 2024

https://peps.python.org/pep-0514/

We use py to find Python installations on Windows today but we want to switch to registry look-ups per PEP 514
@zanieb zanieb added the windows Specific to the Windows platform label Feb 16, 2024
@gaborbernat
Copy link
Contributor

Note virtualenv already does this via https://github.com/pypa/virtualenv/blob/main/src/virtualenv/discovery/windows/pep514.py 👍

@gaborbernat gaborbernat mentioned this issue Feb 16, 2024
Closed
@gaborbernat
Copy link
Contributor

tox-uv seems to be failing on Github Actions without this https://github.com/tox-dev/tox-uv/actions/runs/7935511069?pr=2

@T-256 T-256 mentioned this issue Feb 17, 2024
Closed
This was referenced Feb 17, 2024
Closed
Merged
zanieb added a commit that referenced this issue Feb 18, 2024
@zanieb
Add smoke test to CI (#1611)
3b70b42 
Similar idea to #1356 

Attempting to reproduce
#1521 (comment)
@zanieb zanieb mentioned this issue Aug 22, 2024
Closed
@zanieb zanieb added the help wanted Contribution especially encouraged label Aug 22, 2024
konstin added a commit that referenced this issue Aug 28, 2024
@konstin
Use windows registry to discover python
3f393e1 
Our current strategy of parsing the output of `py --list-paths` to get the installed python versions on windows is brittle (#6524, missing `py`, etc.) and it's slow (10ms last time i measured).

Instead, we should behave spec-compliant and read the python versions from the registry following PEP 514.

We're using the official rust-for-windows crates for accessing the registry.

Fixes #1521
Fixes #6524
@konstin konstin mentioned this issue Aug 28, 2024
Merged
konstin added a commit that referenced this issue Aug 28, 2024
@konstin
Use windows registry to discover python
e950624 
Our current strategy of parsing the output of `py --list-paths` to get the installed python versions on windows is brittle (#6524, missing `py`, etc.) and it's slow (10ms last time i measured).

Instead, we should behave spec-compliant and read the python versions from the registry following PEP 514.

We're using the official rust-for-windows crates for accessing the registry.

Fixes #1521
Fixes #6524
konstin added a commit that referenced this issue Aug 28, 2024
@konstin
Use windows registry to discover python
211815f 
Our current strategy of parsing the output of `py --list-paths` to get the installed python versions on windows is brittle (#6524, missing `py`, etc.) and it's slow (10ms last time i measured).

Instead, we should behave spec-compliant and read the python versions from the registry following PEP 514.

We're using the official rust-for-windows crates for accessing the registry.

Fixes #1521
Fixes #6524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Contribution especially encouraged windows Specific to the Windows platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use windows registry to discover python astral-sh/uv
2 participants
@gaborbernat @zanieb