Bump eifinger/setup-rye from v1 to v2 #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove .rye from ruff excludes as it is not added any more by the action
cnpryer
reviewed
Mar 3, 2024
pyproject.toml
Outdated
| @@ -32,5 +32,4 @@ serve-docs = "mkdocs serve" | |||
| members = ["rye-devtools"] | |||
|
|
|||
| [tool.ruff] | |||
| # the .rye folder is added by the rye github action | |||
| exclude = [".rye", ".venv"] | |||
| exclude = [".venv"] | |||
There was a problem hiding this comment.
Is this needed or can we pull this out here too? Doesn't Ruff have a set of defaults it excludes (inlcuding .venv)?
There was a problem hiding this comment.
Yeah. .venv is ignored by default.
There was a problem hiding this comment.
Pushed another commit to remove it too
.venv is ignored by default by ruff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove
.ryefrom ruff excludes as it is not added any more by the actionFixes the workaround introduced in #822