-
-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use 'cargo insta test' in Makefile's test command #777
Conversation
@@ -13,6 +13,10 @@ jobs: | |||
with: | |||
toolchain: stable | |||
- uses: Swatinem/rust-cache@v2 | |||
- name: Install cargo insta | |||
uses: taiki-e/install-action@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you considered using nextest? For rye's small test suite the difference isn't big yet, but for uv it makes difference.
|
I haven't used nextest yet personally, although I've known of it. I've been playing around a little bit with the uv tests just to look around, and I've liked nextest so far. I'd be happy to check that out for this PR. |
I would prefer that the CI invokes a makefile command. Other than that we can try this. |
Okay, I'll revert back to what I had then. I'll push that real quick. If you decide to merge before nextest I'll PR that separately soon. I don't anticipate getting to the nextest PR before wrapping up #759. |
I'm sure it's intentional to not run everything in CI. I felt it might be helpful especially for the CLI to fully run.