Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected PTH203–PTH205 rule descriptions #9914

Merged

Conversation

trag1c
Copy link
Contributor

@trag1c trag1c commented Feb 9, 2024

Summary

Closes #9898.

Test Plan

python scripts/generate_mkdocs.py && mkdocs serve -f mkdocs.public.yml

Copy link
Contributor

github-actions bot commented Feb 9, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+33 -0 violations, +0 -0 fixes in 1 projects; 42 projects unchanged)

aws/aws-sam-cli (+33 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ tests/integration/testdata/start_api/lambda_authorizers/app.py:122:17: E203 [*] Whitespace before ':'
+ tests/integration/testdata/start_api/lambda_authorizers/app.py:123:15: E203 [*] Whitespace before ':'
+ tests/integration/testdata/start_api/lambda_authorizers/app.py:131:8: E221 [*] Multiple spaces before operator
+ tests/integration/testdata/start_api/lambda_authorizers/app.py:132:9: E221 [*] Multiple spaces before operator
+ tests/integration/testdata/start_api/lambda_authorizers/app.py:133:8: E221 [*] Multiple spaces before operator
+ tests/integration/testdata/start_api/lambda_authorizers/app.py:134:10: E221 [*] Multiple spaces before operator
+ tests/integration/testdata/start_api/lambda_authorizers/app.py:135:9: E221 [*] Multiple spaces before operator
+ tests/integration/testdata/start_api/lambda_authorizers/app.py:136:11: E221 [*] Multiple spaces before operator
+ tests/integration/testdata/start_api/lambda_authorizers/app.py:138:8: E221 [*] Multiple spaces before operator
+ tests/integration/testdata/start_api/lambda_authorizers/app.py:140:1: E302 [*] Expected 2 blank lines, found 1
+ tests/integration/testdata/start_api/lambda_authorizers/app.py:14:1: I001 [*] Import block is un-sorted or un-formatted
+ tests/integration/testdata/start_api/lambda_authorizers/app.py:159:5: E303 [*] Too many blank lines (2)
+ tests/integration/testdata/start_api/lambda_authorizers/app.py:17:1: E302 [*] Expected 2 blank lines, found 1
+ tests/integration/testdata/start_api/lambda_authorizers/app.py:203:30: E203 [*] Whitespace before ':'
+ tests/integration/testdata/start_api/lambda_authorizers/app.py:204:29: E203 [*] Whitespace before ':'
+ tests/integration/testdata/start_api/lambda_authorizers/app.py:208:30: E203 [*] Whitespace before ':'
+ tests/integration/testdata/start_api/lambda_authorizers/app.py:209:29: E203 [*] Whitespace before ':'
+ tests/integration/testdata/start_api/lambda_authorizers/app.py:212:9: PLR6301 Method `_getEmptyStatement` could be a function, class method, or static method
+ tests/integration/testdata/start_api/lambda_authorizers/app.py:284:26: E203 [*] Whitespace before ':'
+ tests/integration/testdata/start_api/lambda_authorizers/app.py:285:29: E203 [*] Whitespace before ':'
+ tests/integration/testdata/start_api/lambda_authorizers/app.py:286:26: E203 [*] Whitespace before ':'
... 8 additional changes omitted for rule E203
+ tests/integration/testdata/start_api/lambda_authorizers/app.py:34:1: E302 [*] Expected 2 blank lines, found 1
+ tests/integration/testdata/start_api/lambda_authorizers/app.py:44:1: E302 [*] Expected 2 blank lines, found 1
+ tests/integration/testdata/start_api/lambda_authorizers/app.py:47:1: E302 [*] Expected 2 blank lines, found 1
+ tests/integration/testdata/start_api/lambda_authorizers/app.py:59:1: E302 [*] Expected 2 blank lines, found 1
+ tests/integration/testdata/start_api/lambda_authorizers/app.py:68:1: E302 [*] Expected 2 blank lines, found 1

Changes by rule (6 rules affected)

code total + violation - violation + fix - fix
E203 16 16 0 0 0
E221 7 7 0 0 0
E302 7 7 0 0 0
I001 1 1 0 0 0
E303 1 1 0 0 0
PLR6301 1 1 0 0 0

Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charliermarsh charliermarsh added the documentation Improvements or additions to documentation label Feb 9, 2024
@charliermarsh charliermarsh merged commit 7ca515c into astral-sh:main Feb 9, 2024
16 of 17 checks passed
nkxxll pushed a commit to nkxxll/ruff that referenced this pull request Mar 10, 2024
## Summary
Closes astral-sh#9898.

## Test Plan
```sh
python scripts/generate_mkdocs.py && mkdocs serve -f mkdocs.public.yml
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rules PTH202–PTH205 have the same description
2 participants