Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out test rules in RuleSelector JSON schema #9901

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

MichaReiser
Copy link
Member

Summary

Running cargo test fails today because cargo dev generate-all runs with the test-rules feature enabled (because ruff enables the feature), which results in the test rules showing up in the JSON schema.

This PR fixes this by filtering out the test rules if the test-rules feature is enabled. I don't particularly like it but how it is today is very disruptive to the development workflow.

Test Plan

cargo test no longer fails

Copy link
Contributor

github-actions bot commented Feb 8, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okeee thanks for cleaning up after me

@zanieb zanieb added the internal An internal refactor or improvement label Feb 8, 2024
@MichaReiser MichaReiser merged commit 49c5e71 into main Feb 8, 2024
17 checks passed
@MichaReiser MichaReiser deleted the filter-out-test-rules-in-json-schema branch February 8, 2024 21:06
nkxxll pushed a commit to nkxxll/ruff that referenced this pull request Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants