Improve trailing comma rule performance #9867
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'm not sure what precisely improves performance but these are the things I did:
flatten
,filter_map
,chain
,coalesce
,tuple_windows
. Now it's justfilter_map
I would have expected that Rust sees through that but maybe it does not.TokenType
variants to matchTok
.... I doubt that this has any impactToken::from
from&Spanned
to(&Tok, TextRange)
.context.last()
when we already set the context in the branch aboveTest Plan
cargo test