Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pylint] Add __mro_entries__ to known dunder methods (PLW3201) #9706

Merged
merged 2 commits into from
Jan 30, 2024
Merged

[pylint] Add __mro_entries__ to known dunder methods (PLW3201) #9706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbe4ff6
Add `__mro_entries__` to known dunder methods
bswck Jan 30, 2024
8893a3c
Test `__mro_entries__` against known dunder methods
bswck Jan 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions crates/ruff_linter/resources/test/fixtures/pylint/bad_dunder_method_name.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,9 @@ def __special_custom_magic__(self):
def __prepare__():
pass

def __mro_entries__(self, bases):
pass


def __foo_bar__(): # this is not checked by the [bad-dunder-name] rule
...
1 change: 1 addition & 0 deletions crates/ruff_linter/src/rules/pylint/helpers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,7 @@ pub(super) fn is_known_dunder_method(method: &str) -> bool {
| "__missing__"
| "__mod__"
| "__module__"
| "__mro_entries__"
| "__mul__"
| "__ne__"
| "__neg__"
Expand Down
Loading