-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pylint
] Add fix for collapsible-else-if
(PLR5501
)
#9594
Merged
charliermarsh
merged 7 commits into
astral-sh:main
from
diceroll123:add-fix-for-PLR5501
Jan 22, 2024
Merged
[pylint
] Add fix for collapsible-else-if
(PLR5501
)
#9594
charliermarsh
merged 7 commits into
astral-sh:main
from
diceroll123:add-fix-for-PLR5501
Jan 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diceroll123
force-pushed
the
add-fix-for-PLR5501
branch
from
January 20, 2024 22:55
6cb0b69
to
a2397db
Compare
diceroll123
changed the title
[pylint] - add fix for
[Jan 20, 2024
collapsible-else-if
/ PLR5501
pylint
] - add fix for collapsible-else-if
/ PLR5501
|
code | total | + violation | - violation | + fix | - fix |
---|---|---|---|---|---|
PLR5501 | 142 | 0 | 0 | 142 | 0 |
diceroll123
changed the title
[
[Jan 21, 2024
pylint
] - add fix for collapsible-else-if
/ PLR5501
pylint
] - add fix for collapsible-else-if
(PLR5501
)
diceroll123
force-pushed
the
add-fix-for-PLR5501
branch
from
January 21, 2024 18:23
a2397db
to
f96365e
Compare
diceroll123
changed the title
[
[Jan 21, 2024
pylint
] - add fix for collapsible-else-if
(PLR5501
)pylint
] - Add fix for collapsible-else-if
(PLR5501
)
charliermarsh
approved these changes
Jan 22, 2024
charliermarsh
added
fixes
Related to suggested fixes for violations
preview
Related to preview mode features
labels
Jan 22, 2024
charliermarsh
changed the title
[
[Jan 22, 2024
pylint
] - Add fix for collapsible-else-if
(PLR5501
)pylint
] Add fix for collapsible-else-if
(PLR5501
)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
adds a fix for
collapsible-else-if
/PLR5501
Test Plan
cargo test